third_party/WebKit/Source/core/paint/FilterEffectBuilder.h - Issue 2044153002: Move ReferenceFilterBuilder::build to FilterEffectBuilder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/FilterEffectBuilder.h

Issue 2044153002: Move ReferenceFilterBuilder::build to FilterEffectBuilder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@filter-remove-reffilter-vector-feb

Patch Set: zoomedReferenceBoxSize Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp ('k') | third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/FilterEffectBuilder.h

diff --git a/third_party/WebKit/Source/core/paint/FilterEffectBuilder.h b/third_party/WebKit/Source/core/paint/FilterEffectBuilder.h

index 443a22c738fd37712e5c4019b82319c25aa8018b..ac81318219a1d147ef28142bbf776cb9e84153a6 100644

--- a/third_party/WebKit/Source/core/paint/FilterEffectBuilder.h

+++ b/third_party/WebKit/Source/core/paint/FilterEffectBuilder.h

@@ -34,8 +34,11 @@ class SkPaint;

namespace blink {

-class FilterOperations;

class Element;

+class FilterOperations;

+class ReferenceFilterOperation;

+class SVGFilterElement;

+class SVGFilterGraphNodeMap;

class CORE_EXPORT FilterEffectBuilder final : public GarbageCollectedFinalized<FilterEffectBuilder> {

public:

@@ -47,7 +50,10 @@ public:

virtual ~FilterEffectBuilder();

DECLARE_TRACE();

- bool build(Element*, const FilterOperations&, float zoom, const FloatSize* referenceBoxSize = nullptr, const SkPaint* fillPaint = nullptr, const SkPaint* strokePaint = nullptr);

+ static Filter* buildReferenceFilter(const ReferenceFilterOperation&, const FloatSize* zoomedReferenceBoxSize, const SkPaint* fillPaint, const SkPaint* strokePaint, Element&, FilterEffect* previousEffect, float zoom);

+ static Filter* buildReferenceFilter(SVGFilterElement&, const FloatRect& referenceBox, const SkPaint* fillPaint, const SkPaint* strokePaint, FilterEffect* previousEffect, float zoom, SVGFilterGraphNodeMap* = nullptr);

+ bool build(Element*, const FilterOperations&, float zoom, const FloatSize* zoomedReferenceBoxSize = nullptr, const SkPaint* fillPaint = nullptr, const SkPaint* strokePaint = nullptr);

FilterEffect* lastEffect() const

{