Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2043013002: Drop FilterEffectBuilder::m_referenceFilters (Closed)

Created:
4 years, 6 months ago by fs
Modified:
4 years, 6 months ago
Reviewers:
sof
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop FilterEffectBuilder::m_referenceFilters The job of this Vector used to be to keep a reference to the nested "reference" filters, to avoid them being destroyed. The entire filter graph/chain is now on the GC heap, and traced via FilterEffectBuilder::m_lastEffect, so this additional reference is of no use. Committed: https://crrev.com/7815ed56eb95640ecbfb7b8d34ab27c5052d164e Cr-Commit-Position: refs/heads/master@{#398341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M third_party/WebKit/Source/core/paint/FilterEffectBuilder.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp View 3 chunks +1 line, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
fs
4 years, 6 months ago (2016-06-07 11:31:25 UTC) #2
sof
lgtm
4 years, 6 months ago (2016-06-07 11:42:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043013002/1
4 years, 6 months ago (2016-06-07 11:43:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/234544)
4 years, 6 months ago (2016-06-07 16:06:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043013002/1
4 years, 6 months ago (2016-06-07 16:32:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 18:13:15 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 18:15:11 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7815ed56eb95640ecbfb7b8d34ab27c5052d164e
Cr-Commit-Position: refs/heads/master@{#398341}

Powered by Google App Engine
This is Rietveld 408576698