Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1143)

Issue 2043723002: Make type-feedback-vector.h be self-contained. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make type-feedback-vector.h be self-contained. This allows the header in question to be included without including any other header files. This is step towards factory.h being self-contained. R=clemensh@chromium.org Committed: https://crrev.com/3910f6dfea5dc0ffd53a3ee00a587d9e4574bb5c Cr-Commit-Position: refs/heads/master@{#36752}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -16 lines) Patch
M src/type-feedback-vector.h View 3 chunks +4 lines, -10 lines 0 comments Download
M src/type-feedback-vector.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/type-feedback-vector-inl.h View 2 chunks +15 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
Michael Starzinger
Clemens: PTAL. Michael: FYI.
4 years, 6 months ago (2016-06-06 13:50:47 UTC) #2
mvstanton
lgtm
4 years, 6 months ago (2016-06-06 13:51:58 UTC) #3
Clemens Hammacher
lgtm thanks!
4 years, 6 months ago (2016-06-06 14:03:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2043723002/1
4 years, 6 months ago (2016-06-06 14:08:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 14:17:36 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 14:17:55 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3910f6dfea5dc0ffd53a3ee00a587d9e4574bb5c
Cr-Commit-Position: refs/heads/master@{#36752}

Powered by Google App Engine
This is Rietveld 408576698