Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: src/type-feedback-vector.h

Issue 2043723002: Make type-feedback-vector.h be self-contained. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/type-feedback-vector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/type-feedback-vector.h
diff --git a/src/type-feedback-vector.h b/src/type-feedback-vector.h
index f4f1f2c1203e0ae3c48c29a4f0c3e5e2b013a615..bf09e1df5d9cb4a03644ac7bd2e2f3edd4c90a8c 100644
--- a/src/type-feedback-vector.h
+++ b/src/type-feedback-vector.h
@@ -209,7 +209,7 @@ class TypeFeedbackVector : public FixedArray {
WriteBarrierMode mode = UPDATE_WRITE_BARRIER);
// Returns slot kind for given slot.
- inline FeedbackVectorSlotKind GetKind(FeedbackVectorSlot slot) const;
+ FeedbackVectorSlotKind GetKind(FeedbackVectorSlot slot) const;
static Handle<TypeFeedbackVector> New(Isolate* isolate,
Handle<TypeFeedbackMetadata> metadata);
@@ -292,15 +292,9 @@ class TypeFeedbackMetadataIterator {
slot_(FeedbackVectorSlot(0)),
slot_kind_(FeedbackVectorSlotKind::INVALID) {}
- bool HasNext() const { return slot_.ToInt() < metadata()->slot_count(); }
+ inline bool HasNext() const;
- FeedbackVectorSlot Next() {
- DCHECK(HasNext());
- FeedbackVectorSlot slot = slot_;
- slot_kind_ = metadata()->GetKind(slot);
- slot_ = FeedbackVectorSlot(slot_.ToInt() + entry_size());
- return slot;
- }
+ inline FeedbackVectorSlot Next();
// Returns slot kind of the last slot returned by Next().
FeedbackVectorSlotKind kind() const {
@@ -310,7 +304,7 @@ class TypeFeedbackMetadataIterator {
}
// Returns entry size of the last slot returned by Next().
- int entry_size() const { return TypeFeedbackMetadata::GetSlotSize(kind()); }
+ inline int entry_size() const;
private:
TypeFeedbackMetadata* metadata() const {
« no previous file with comments | « no previous file | src/type-feedback-vector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698