Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2039913002: Make api-arguments.h not include inline headers. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-includes-type-feedback-vector
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make api-arguments.h not include inline headers. This avoids the inclusion of inline headers (i.e. vm-state-inl.h in this case) in a normal header. There are three more such violations left in the code-base after this change. R=verwaest@chromium.org Committed: https://crrev.com/ea59da53ba5dd940430b4be8c8a57a692e897f39 Cr-Commit-Position: refs/heads/master@{#36781}

Patch Set 1 #

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -88 lines) Patch
M BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/api-arguments.h View 1 2 chunks +14 lines, -84 lines 0 comments Download
M src/api-arguments.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
A src/api-arguments-inl.h View 1 1 chunk +105 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/objects.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/v8.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (2 generated)
Michael Starzinger
4 years, 6 months ago (2016-06-06 14:08:49 UTC) #1
Toon Verwaest
The code in api-arguments.h is very performance sensitive. We should make sure it's still inlined ...
4 years, 6 months ago (2016-06-06 15:05:07 UTC) #2
Michael Starzinger
Thanks! Addressed comments. PTAL.
4 years, 6 months ago (2016-06-06 15:46:09 UTC) #3
Toon Verwaest
lgtm, thanks
4 years, 6 months ago (2016-06-07 09:13:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2039913002/20001
4 years, 6 months ago (2016-06-07 09:46:08 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-07 09:48:13 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 09:50:11 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ea59da53ba5dd940430b4be8c8a57a692e897f39
Cr-Commit-Position: refs/heads/master@{#36781}

Powered by Google App Engine
This is Rietveld 408576698