Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: src/prototype.h

Issue 2043183003: Replace all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: simplifying checks Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/prototype.h
diff --git a/src/prototype.h b/src/prototype.h
index e09ff0ff0cd28edc6d0c5d86c8d13c4e21fc708e..241418d8131e270db3315cad32dd84fc1d600396 100644
--- a/src/prototype.h
+++ b/src/prototype.h
@@ -59,14 +59,14 @@ class PrototypeIterator {
: object_(receiver_map->prototype()),
isolate_(receiver_map->GetIsolate()),
where_to_end_(END_AT_NULL),
- is_at_end_(object_->IsNull()) {}
+ is_at_end_(object_->IsNull(isolate_)) {}
explicit PrototypeIterator(Handle<Map> receiver_map)
: object_(NULL),
handle_(handle(receiver_map->prototype(), receiver_map->GetIsolate())),
isolate_(receiver_map->GetIsolate()),
where_to_end_(END_AT_NULL),
- is_at_end_(handle_->IsNull()) {}
+ is_at_end_(handle_->IsNull(isolate_)) {}
~PrototypeIterator() {}
@@ -114,7 +114,7 @@ class PrototypeIterator {
Object* prototype = map->prototype();
is_at_end_ = where_to_end_ == END_AT_NON_HIDDEN
? !map->has_hidden_prototype()
- : prototype->IsNull();
+ : prototype->IsNull(isolate_);
if (handle_.is_null()) {
object_ = prototype;
@@ -153,7 +153,8 @@ class PrototypeIterator {
MaybeHandle<Object> proto =
JSProxy::GetPrototype(Handle<JSProxy>::cast(handle_));
if (!proto.ToHandle(&handle_)) return false;
- is_at_end_ = where_to_end_ == END_AT_NON_HIDDEN || handle_->IsNull();
+ is_at_end_ =
+ where_to_end_ == END_AT_NON_HIDDEN || handle_->IsNull(isolate_);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698