src/objects-printer.cc - Issue 2043183003: Replace all remaining Oddball checks with new function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-printer.cc

Issue 2043183003: Replace all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: simplifying checks Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-printer.cc

diff --git a/src/objects-printer.cc b/src/objects-printer.cc

index d1a1391a5cf2315d84f8c678e54ca68e193dc318..4a6dd63a32c3342d6e1b919be1821c66b4d6ea02 100644

--- a/src/objects-printer.cc

+++ b/src/objects-printer.cc

@@ -1191,7 +1191,7 @@ void LayoutDescriptor::Print() {

void LayoutDescriptor::Print(std::ostream& os) { // NOLINT

os << "Layout descriptor: ";

- if (IsUninitialized()) {

+ if (IsOddball() && IsUninitialized(HeapObject::cast(this)->GetIsolate())) {

os << "<uninitialized>";

} else if (IsFastPointerLayout()) {

os << "<all tagged>";

« src/objects-inl.h ('K') | « src/objects-inl.h ('k') | src/prototype.h » ('j') | no next file with comments »