src/regexp/regexp-macro-assembler.cc - Issue 2043183003: Replace all remaining Oddball checks with new function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/regexp/regexp-macro-assembler.cc

Issue 2043183003: Replace all remaining Oddball checks with new function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: simplifying checks Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/regexp/regexp-macro-assembler.cc

diff --git a/src/regexp/regexp-macro-assembler.cc b/src/regexp/regexp-macro-assembler.cc

index 7fed26e487edda82efade35bfe84d46024db6502..19ecaed18f84f02a6df5eebd916c438e8be30051 100644

--- a/src/regexp/regexp-macro-assembler.cc

+++ b/src/regexp/regexp-macro-assembler.cc

@@ -177,7 +177,7 @@ int NativeRegExpMacroAssembler::CheckStackGuardState(

return_value = RETRY;

} else {

Object* result = isolate->stack_guard()->HandleInterrupts();

- if (result->IsException()) return_value = EXCEPTION;

+ if (result->IsException(isolate)) return_value = EXCEPTION;

}

DisallowHeapAllocation no_gc;