Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp

Issue 2043013002: Drop FilterEffectBuilder::m_referenceFilters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/paint/FilterEffectBuilder.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp
diff --git a/third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp b/third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp
index 324ff33469bab8e4a700543bbb2eabd1da7ac345..9241542c378224c90dbe0c2cd471410271bf0f9e 100644
--- a/third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp
+++ b/third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp
@@ -129,7 +129,6 @@ FilterEffectBuilder::~FilterEffectBuilder()
DEFINE_TRACE(FilterEffectBuilder)
{
visitor->trace(m_lastEffect);
- visitor->trace(m_referenceFilters);
}
bool FilterEffectBuilder::build(Element* element, const FilterOperations& operations, float zoom, const FloatSize* referenceBoxSize, const SkPaint* fillPaint, const SkPaint* strokePaint)
@@ -143,10 +142,8 @@ bool FilterEffectBuilder::build(Element* element, const FilterOperations& operat
switch (filterOperation->type()) {
case FilterOperation::REFERENCE: {
Filter* referenceFilter = ReferenceFilterBuilder::build(zoom, element, previousEffect, toReferenceFilterOperation(*filterOperation), referenceBoxSize, fillPaint, strokePaint);
- if (referenceFilter) {
+ if (referenceFilter)
effect = referenceFilter->lastEffect();
- m_referenceFilters.append(referenceFilter);
- }
break;
}
case FilterOperation::GRAYSCALE: {
@@ -252,8 +249,6 @@ bool FilterEffectBuilder::build(Element* element, const FilterOperations& operat
}
}
- m_referenceFilters.append(parentFilter);
-
// We need to keep the old effects alive until this point, so that SVG reference filters
// can share cached resources across frames.
m_lastEffect = previousEffect;
« no previous file with comments | « third_party/WebKit/Source/core/paint/FilterEffectBuilder.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698