Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2042703002: Handle 'visibility:collapse' for SVG shapes/images/text-decorations (Closed)

Created:
4 years, 6 months ago by Shanmuga Pandi
Modified:
4 years, 6 months ago
Reviewers:
pdr, pdr., f(malita), rwlbuis
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle 'visibility:collapse' for SVG shapes/images/text-decorations SVG shapes/images/text-decoration does not handle 'visibility:collapse' properly. It was just handled only 'visibility:hidden'. BUG=604687 Committed: https://crrev.com/32cb486ad01dcc6963ddec89a4d562f60f17e6d9 Cr-Commit-Position: refs/heads/master@{#398808}

Patch Set 1 #

Patch Set 2 : Removed resource file #

Total comments: 4

Patch Set 3 : Align with review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/svg/custom/visibility-collapse.html View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/custom/visibility-collapse-expected.html View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGImagePainter.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGShapePainter.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 29 (13 generated)
Shanmuga Pandi
4 years, 6 months ago (2016-06-06 05:53:09 UTC) #2
Shanmuga Pandi
PTAL!! Thanks
4 years, 6 months ago (2016-06-06 05:53:27 UTC) #3
rwlbuis
On 2016/06/06 05:53:27, Shanmuga Pandi wrote: > PTAL!! > > Thanks Peer looks good to ...
4 years, 6 months ago (2016-06-06 14:08:22 UTC) #5
Shanmuga Pandi
On 2016/06/06 14:08:22, rwlbuis wrote: > On 2016/06/06 05:53:27, Shanmuga Pandi wrote: > > PTAL!! ...
4 years, 6 months ago (2016-06-07 05:38:05 UTC) #6
Shanmuga Pandi
@pdr PTAL.. Thanks
4 years, 6 months ago (2016-06-07 05:39:02 UTC) #8
Shanmuga Pandi
4 years, 6 months ago (2016-06-07 10:30:10 UTC) #10
pdr.
https://codereview.chromium.org/2042703002/diff/20001/third_party/WebKit/LayoutTests/svg/custom/visibility-collapse.html File third_party/WebKit/LayoutTests/svg/custom/visibility-collapse.html (right): https://codereview.chromium.org/2042703002/diff/20001/third_party/WebKit/LayoutTests/svg/custom/visibility-collapse.html#newcode1 third_party/WebKit/LayoutTests/svg/custom/visibility-collapse.html:1: <svg> Add <!DOCTYPE HTML> as the first line here, ...
4 years, 6 months ago (2016-06-07 23:02:25 UTC) #12
Shanmuga Pandi
Done the changes. Please review https://codereview.chromium.org/2042703002/diff/20001/third_party/WebKit/LayoutTests/svg/custom/visibility-collapse.html File third_party/WebKit/LayoutTests/svg/custom/visibility-collapse.html (right): https://codereview.chromium.org/2042703002/diff/20001/third_party/WebKit/LayoutTests/svg/custom/visibility-collapse.html#newcode1 third_party/WebKit/LayoutTests/svg/custom/visibility-collapse.html:1: <svg> On 2016/06/07 23:02:25, ...
4 years, 6 months ago (2016-06-08 05:17:13 UTC) #13
pdr.
lgtm
4 years, 6 months ago (2016-06-08 05:20:18 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042703002/40001
4 years, 6 months ago (2016-06-08 05:20:29 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/235230)
4 years, 6 months ago (2016-06-08 09:56:14 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042703002/40001
4 years, 6 months ago (2016-06-08 13:01:19 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/235370)
4 years, 6 months ago (2016-06-08 18:20:15 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042703002/40001
4 years, 6 months ago (2016-06-09 04:48:41 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-09 07:41:50 UTC) #27
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 07:43:41 UTC) #29
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/32cb486ad01dcc6963ddec89a4d562f60f17e6d9
Cr-Commit-Position: refs/heads/master@{#398808}

Powered by Google App Engine
This is Rietveld 408576698