third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp - Issue 2042703002: Handle 'visibility:collapse' for SVG shapes/images/text-decorations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp

Issue 2042703002: Handle 'visibility:collapse' for SVG shapes/images/text-decorations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Align with review comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/SVGImagePainter.cpp ('k') | third_party/WebKit/Source/core/paint/SVGShapePainter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp b/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp

index c039a6a043de7176aa7e0c3b2a4ce7c817563d0d..9cc33a14db2a209895dd9f4a885c58881434c53a 100644

--- a/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp

@@ -233,7 +233,7 @@ void SVGInlineTextBoxPainter::paintDecoration(const PaintInfo& paintInfo, TextDe

LayoutObject* decorationLayoutObject = findLayoutObjectDefininingTextDecoration(m_svgInlineTextBox.parent());

const ComputedStyle& decorationStyle = decorationLayoutObject->styleRef();

- if (decorationStyle.visibility() == HIDDEN)

+ if (decorationStyle.visibility() != VISIBLE)

return;

float scalingFactor = 1;