third_party/WebKit/Source/core/paint/SVGShapePainter.cpp - Issue 2042703002: Handle 'visibility:collapse' for SVG shapes/images/text-decorations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/SVGShapePainter.cpp

Issue 2042703002: Handle 'visibility:collapse' for SVG shapes/images/text-decorations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Align with review comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/paint/SVGShapePainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/SVGShapePainter.cpp b/third_party/WebKit/Source/core/paint/SVGShapePainter.cpp

index 3862fc28700e64bd8bab6eaebfe854ee4222c936..380e8d89cf7fc3b3c22cbdf48cebb8fb0b379a9f 100644

--- a/third_party/WebKit/Source/core/paint/SVGShapePainter.cpp

+++ b/third_party/WebKit/Source/core/paint/SVGShapePainter.cpp

@@ -43,7 +43,7 @@ static SkPath::FillType fillRuleFromStyle(const PaintInfo& paintInfo, const SVGC

void SVGShapePainter::paint(const PaintInfo& paintInfo)

{

if (paintInfo.phase != PaintPhaseForeground

- || m_layoutSVGShape.style()->visibility() == HIDDEN

+ || m_layoutSVGShape.style()->visibility() != VISIBLE

|| m_layoutSVGShape.isShapeEmpty())

return;

« no previous file with comments | « third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp ('k') | no next file » | no next file with comments »