[icu] Support loading data file from default location

[icu] Support loading data file from default location

This allows using icu data, bundled in the icudtl.dat file,
to be loaded automatically from a default location
side-by-side with the executable.

The v8 stand-alone default is still to use statically
linked ICU data, but this will be switched in a separate
follow-up CL.

BUG=chromium:616033
LOG=y

Committed: https://crrev.com/cec0ed0f77e91bfd49bbd298ab58f77375eecead
Cr-Commit-Position: refs/heads/master@{#36823}

[Michael Achenbach, 2016-06-07 12:48:54]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-07 12:48:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2042253002/20001

[commit-bot: I haz the power, 2016-06-07 12:50:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 12:50:27]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_mac_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/2752)

[Michael Achenbach, 2016-06-07 12:57:25]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-07 12:57:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2042253002/40001

[Michael Achenbach, 2016-06-07 13:12:15]

Description was changed from

==========
[icu] Support loading data file from default location

BUG=
==========

to

==========
[icu] Support loading data file from default location

This allows using icu data bundled in the icudtl.dat file
to be loaded automatically from a default location
side-by-side with the executable.

The v8 stand-alone default is still to use statically
linked ICU data, but this will be switched in a separate
follow-up CL.

BUG=chromium:616033
LOG=y
==========

[Michael Achenbach, 2016-06-07 13:12:26]

Description was changed from

==========
[icu] Support loading data file from default location

This allows using icu data bundled in the icudtl.dat file
to be loaded automatically from a default location
side-by-side with the executable.

The v8 stand-alone default is still to use statically
linked ICU data, but this will be switched in a separate
follow-up CL.

BUG=chromium:616033
LOG=y
==========

to

==========
[icu] Support loading data file from default location

This allows using icu data, bundled in the icudtl.dat file,
to be loaded automatically from a default location
side-by-side with the executable.

The v8 stand-alone default is still to use statically
linked ICU data, but this will be switched in a separate
follow-up CL.

BUG=chromium:616033
LOG=y
==========

[Michael Achenbach, 2016-06-07 13:14:04]

machenbach@chromium.org changed reviewers:
+ jochen@chromium.org, vogelheim@chromium.org

[Michael Achenbach, 2016-06-07 13:14:33]

PTAL

[commit-bot: I haz the power, 2016-06-07 13:25:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 13:25:08]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-06-07 19:05:44]

https://codereview.chromium.org/2042253002/diff/40001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2042253002/diff/40001/include/v8.h#newcode6717
include/v8.h:6717: * Returns true on success.
or icudtl.dll on windows

https://codereview.chromium.org/2042253002/diff/40001/include/v8.h#newcode6722
include/v8.h:6722: static bool InitializeICUDefaultLocation(const char*
exec_path,
what about just replacing the old API? Or at least mark it as deprecate_soon?

https://codereview.chromium.org/2042253002/diff/40001/include/v8.h#newcode6723
include/v8.h:6723: const char* icu_data_file = NULL);
nullptr

https://codereview.chromium.org/2042253002/diff/40001/src/file-utils.h
File src/file-utils.h (right):

https://codereview.chromium.org/2042253002/diff/40001/src/file-utils.h#newcode6
src/file-utils.h:6: #define V8_FILE_UTILS_H_
maybe make that part of src/base ?

[Michael Achenbach, 2016-06-08 07:08:18]

https://codereview.chromium.org/2042253002/diff/40001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2042253002/diff/40001/include/v8.h#newcode6717
include/v8.h:6717: * Returns true on success.
On 2016/06/07 19:05:44, jochen wrote:
> or icudtl.dll on windows

Don't understand. This is only about the data file not the dynamic library. The
data file is the same on windows, no? E.g. I see it here being packed:
https://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/25121...

I don't see the dll there.

https://codereview.chromium.org/2042253002/diff/40001/include/v8.h#newcode6722
include/v8.h:6722: static bool InitializeICUDefaultLocation(const char*
exec_path,
On 2016/06/07 19:05:44, jochen wrote:
> what about just replacing the old API? Or at least mark it as deprecate_soon?

Is chromium at all using the old API? They must have their own mechanism for
initializing ICU, right?

[Michael Achenbach, 2016-06-08 07:44:22]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-08 07:44:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2042253002/60001

[commit-bot: I haz the power, 2016-06-08 07:46:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 07:46:36]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/6916)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_mac_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/2811)

[Michael Achenbach, 2016-06-08 07:50:31]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-08 07:50:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2042253002/80001

[commit-bot: I haz the power, 2016-06-08 07:54:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 07:54:45]

Dry run: Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/16718)

[Michael Achenbach, 2016-06-08 07:59:44]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-08 07:59:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2042253002/100001

[Michael Achenbach, 2016-06-08 08:00:25]

All done. PTAL

https://codereview.chromium.org/2042253002/diff/40001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2042253002/diff/40001/include/v8.h#newcode6717
include/v8.h:6717: * Returns true on success.
On 2016/06/08 07:08:18, Michael Achenbach wrote:
> On 2016/06/07 19:05:44, jochen wrote:
> > or icudtl.dll on windows
> 
> Don't understand. This is only about the data file not the dynamic library.
The
> data file is the same on windows, no? E.g. I see it here being packed:
>
https://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/25121...
> 
> I don't see the dll there.

I rewrote the docu a bit.

https://codereview.chromium.org/2042253002/diff/40001/include/v8.h#newcode6722
include/v8.h:6722: static bool InitializeICUDefaultLocation(const char*
exec_path,
On 2016/06/08 07:08:18, Michael Achenbach wrote:
> On 2016/06/07 19:05:44, jochen wrote:
> > what about just replacing the old API? Or at least mark it as
deprecate_soon?
> 
> Is chromium at all using the old API? They must have their own mechanism for
> initializing ICU, right?

Marked.

https://codereview.chromium.org/2042253002/diff/40001/include/v8.h#newcode6723
include/v8.h:6723: const char* icu_data_file = NULL);
On 2016/06/07 19:05:44, jochen wrote:
> nullptr

Done. Also in the old api.

https://codereview.chromium.org/2042253002/diff/40001/src/file-utils.h
File src/file-utils.h (right):

https://codereview.chromium.org/2042253002/diff/40001/src/file-utils.h#newcode6
src/file-utils.h:6: #define V8_FILE_UTILS_H_
On 2016/06/07 19:05:44, jochen wrote:
> maybe make that part of src/base ?

Done.

[commit-bot: I haz the power, 2016-06-08 08:27:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 08:27:44]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2016-06-08 09:01:59]

lgtm

[Michael Achenbach, 2016-06-08 09:27:55]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-06-08 09:28:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2042253002/100001

[commit-bot: I haz the power, 2016-06-08 09:32:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 09:32:16]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/16731)

[Michael Achenbach, 2016-06-08 09:34:10]

machenbach@chromium.org changed reviewers:
+ yangguo@chromium.org

[Michael Achenbach, 2016-06-08 09:34:11]

+ yangguo or vogelheim for owners lgtm of snapshot.cc

[Yang, 2016-06-08 12:03:30]

On 2016/06/08 09:34:11, Michael Achenbach wrote:
> + yangguo or vogelheim for owners lgtm of snapshot.cc

lgtm.

[Michael Achenbach, 2016-06-08 12:06:55]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-06-08 12:07:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2042253002/100001

[commit-bot: I haz the power, 2016-06-08 12:09:30]

Description was changed from

==========
[icu] Support loading data file from default location

This allows using icu data, bundled in the icudtl.dat file,
to be loaded automatically from a default location
side-by-side with the executable.

The v8 stand-alone default is still to use statically
linked ICU data, but this will be switched in a separate
follow-up CL.

BUG=chromium:616033
LOG=y
==========

to

==========
[icu] Support loading data file from default location

This allows using icu data, bundled in the icudtl.dat file,
to be loaded automatically from a default location
side-by-side with the executable.

The v8 stand-alone default is still to use statically
linked ICU data, but this will be switched in a separate
follow-up CL.

BUG=chromium:616033
LOG=y
==========

[commit-bot: I haz the power, 2016-06-08 12:09:31]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-08 12:11:39]

Description was changed from

==========
[icu] Support loading data file from default location

This allows using icu data, bundled in the icudtl.dat file,
to be loaded automatically from a default location
side-by-side with the executable.

The v8 stand-alone default is still to use statically
linked ICU data, but this will be switched in a separate
follow-up CL.

BUG=chromium:616033
LOG=y
==========

to

==========
[icu] Support loading data file from default location

This allows using icu data, bundled in the icudtl.dat file,
to be loaded automatically from a default location
side-by-side with the executable.

The v8 stand-alone default is still to use statically
linked ICU data, but this will be switched in a separate
follow-up CL.

BUG=chromium:616033
LOG=y

Committed: https://crrev.com/cec0ed0f77e91bfd49bbd298ab58f77375eecead
Cr-Commit-Position: refs/heads/master@{#36823}
==========

[commit-bot: I haz the power, 2016-06-08 12:11:41]

Patchset 6 (id:??) landed as
https://crrev.com/cec0ed0f77e91bfd49bbd298ab58f77375eecead
Cr-Commit-Position: refs/heads/master@{#36823}