[icu] Support loading data file from default location

include/v8.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** \mainpage V8 API Reference Guide
  *
  * V8 is Google's open source JavaScript engine.
  *
  * This set of documents provides reference material generated from the
  * V8 header file, include/v8.h.
@@ skipping 6692 matching lines @@
   /**
    * Initialize the ICU library bundled with V8. The embedder should only
    * invoke this method when using the bundled ICU. Returns true on success.
    *
    * If V8 was compiled with the ICU data in an external file, the location
    * of the data file has to be provided.
    */
   static bool InitializeICU(const char* icu_data_file = NULL);
 
   /**
+   * Initialize the ICU library bundled with V8. The embedder should only
+   * invoke this method when V8 was compiled with the ICU data in an external
+   * file and when the default location of that file should be used. The
+   * default is a file called icudtl.dat side-by-side with the executable.
+   * Returns true on success.

[jochen (gone - plz use gerrit), 2016/06/07 19:05:44]

or icudtl.dll on windows

[Michael Achenbach, 2016/06/08 07:08:18]

Don't understand. This is only about the data file not the dynamic library. The
data file is the same on windows, no? E.g. I see it here being packed:
https://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/25121...

I don't see the dll there.

[Michael Achenbach, 2016/06/08 08:00:25]

I rewrote the docu a bit.

+   *
+   * A path to the executable must be provided. Optionally, the location of the
+   * data file can be provided to override the default.
+   */
+  static bool InitializeICUDefaultLocation(const char* exec_path,

[jochen (gone - plz use gerrit), 2016/06/07 19:05:44]

what about just replacing the old API? Or at least mark it as deprecate_soon?

[Michael Achenbach, 2016/06/08 07:08:18]

Is chromium at all using the old API? They must have their own mechanism for
initializing ICU, right?

[Michael Achenbach, 2016/06/08 08:00:25]

Marked.

+                                           const char* icu_data_file = NULL);

[jochen (gone - plz use gerrit), 2016/06/07 19:05:44]

nullptr

[Michael Achenbach, 2016/06/08 08:00:25]

Done. Also in the old api.

+
+  /**
    * Initialize the external startup data. The embedder only needs to
    * invoke this method when external startup data was enabled in a build.
    *
    * If V8 was compiled with the startup data in an external file, then
    * V8 needs to be given those external files during startup. There are
    * three ways to do this:
    * - InitializeExternalStartupData(const char*)
    *   This will look in the given directory for files "natives_blob.bin"
    *   and "snapshot_blob.bin" - which is what the default build calls them.
    * - InitializeExternalStartupData(const char*, const char*)
@@ skipping 2106 matching lines @@
  */
 
 
 }  // namespace v8
 
 
 #undef TYPE_CHECK
 
 
 #endif  // INCLUDE_V8_H_