Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: include/v8.h

Issue 2042253002: [icu] Support loading data file from default location (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Format Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | samples/hello-world.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 1c50d9b473b916ac115e58cd2ae6f9c92990beb4..689632e3549a9d1e364ba5abcb8524afd7488602 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -6707,7 +6707,24 @@ class V8_EXPORT V8 {
* If V8 was compiled with the ICU data in an external file, the location
* of the data file has to be provided.
*/
- static bool InitializeICU(const char* icu_data_file = NULL);
+ V8_DEPRECATE_SOON(
+ "Use version with default location.",
+ static bool InitializeICU(const char* icu_data_file = nullptr));
+
+ /**
+ * Initialize the ICU library bundled with V8. The embedder should only
+ * invoke this method when using the bundled ICU. If V8 was compiled with
+ * the ICU data in an external file and when the default location of that
+ * file should be used, a path to the executable must be provided.
+ * Returns true on success.
+ *
+ * The default is a file called icudtl.dat side-by-side with the executable.
+ *
+ * Optionally, the location of the data file can be provided to override the
+ * default.
+ */
+ static bool InitializeICUDefaultLocation(const char* exec_path,
+ const char* icu_data_file = nullptr);
/**
* Initialize the external startup data. The embedder only needs to
« no previous file with comments | « BUILD.gn ('k') | samples/hello-world.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698