Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2042213003: Revert of Revert cursor changes to RenderWidgetHostViewAura. (Closed)

Created:
4 years, 6 months ago by scottmg
Modified:
4 years, 6 months ago
Reviewers:
sadrul, Elliot Glaysher
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert cursor changes to RenderWidgetHostViewAura. (patchset #2 id:20001 of https://codereview.chromium.org/2027693003/ ) Reason for revert: Speculative revert for very small likelihood of causing elevated crash rates as detailed in https://bugs.chromium.org/p/chromium/issues/detail?id=616399 Original issue's description: > Revert cursor changes to RenderWidgetHostViewAura. > > This is a selective revert of one file from > https://codereview.chromium.org/1945423002, which was breaking cursor > changes on zoom in/zoom out on the Linux version of chrome. > > BUG=602727, 614654 > > Committed: https://crrev.com/b9020bacdaff760ec0acc4fc5e9db9239438636d > Cr-Commit-Position: refs/heads/master@{#396977} TBR=sadrul@chromium.org,erg@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=602727, 614654 Committed: https://crrev.com/2161ef83c680c890b8f3beacac4984065eb2bd50 Cr-Commit-Position: refs/heads/master@{#398445}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
scottmg
Created Revert of Revert cursor changes to RenderWidgetHostViewAura.
4 years, 6 months ago (2016-06-08 00:09:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2042213003/1
4 years, 6 months ago (2016-06-08 00:09:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 01:03:53 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2161ef83c680c890b8f3beacac4984065eb2bd50 Cr-Commit-Position: refs/heads/master@{#398445}
4 years, 6 months ago (2016-06-08 01:05:51 UTC) #6
scottmg
4 years, 6 months ago (2016-06-16 17:25:26 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2071903003/ by scottmg@chromium.org.

The reason for reverting is: Relanding, didn't seem to help..

Powered by Google App Engine
This is Rietveld 408576698