Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 1945423002: views/mus: Connect cursor events to the mus window. (Closed)

Created:
4 years, 7 months ago by Elliot Glaysher
Modified:
4 years, 7 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, yusukes+watch_chromium.org, tfarina, shuchen+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views/mus: Connect cursor events to the mus window. This makes views programs backed by a mus window able to change the cursor for its bounds. mus already has partial support for per-window cursors, this just needed to be plumbed. BUG=548428 Committed: https://crrev.com/19ddf3a6399fbee33681ea74d41529b4915e9c03 Cr-Commit-Position: refs/heads/master@{#391660}

Patch Set 1 #

Patch Set 2 : Reset the cursor manager when we delete the window it uses. #

Total comments: 2

Patch Set 3 : Add temporary if check. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -3 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M ui/views/mus/native_widget_mus.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 1 2 5 chunks +70 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
Elliot Glaysher
4 years, 7 months ago (2016-05-04 19:27:58 UTC) #2
sky
https://codereview.chromium.org/1945423002/diff/20001/ui/views/mus/native_widget_mus.cc File ui/views/mus/native_widget_mus.cc (right): https://codereview.chromium.org/1945423002/diff/20001/ui/views/mus/native_widget_mus.cc#newcode491 ui/views/mus/native_widget_mus.cc:491: cursor_manager_.reset(new wm::CursorManager( The wm also uses NativeWidgetMus. Do we ...
4 years, 7 months ago (2016-05-04 20:18:59 UTC) #3
Elliot Glaysher
https://codereview.chromium.org/1945423002/diff/20001/ui/views/mus/native_widget_mus.cc File ui/views/mus/native_widget_mus.cc (right): https://codereview.chromium.org/1945423002/diff/20001/ui/views/mus/native_widget_mus.cc#newcode491 ui/views/mus/native_widget_mus.cc:491: cursor_manager_.reset(new wm::CursorManager( On 2016/05/04 20:18:59, sky wrote: > The ...
4 years, 7 months ago (2016-05-04 20:55:02 UTC) #4
sky
LGTM
4 years, 7 months ago (2016-05-04 21:43:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945423002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945423002/40001
4 years, 7 months ago (2016-05-04 21:45:15 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/177789)
4 years, 7 months ago (2016-05-04 21:54:11 UTC) #9
Elliot Glaysher
+sadrul for owners stamp on RWHVA.
4 years, 7 months ago (2016-05-04 21:58:56 UTC) #11
sadrul
lgtm
4 years, 7 months ago (2016-05-04 22:06:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945423002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945423002/40001
4 years, 7 months ago (2016-05-04 22:13:06 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-04 22:18:28 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 22:20:18 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/19ddf3a6399fbee33681ea74d41529b4915e9c03
Cr-Commit-Position: refs/heads/master@{#391660}

Powered by Google App Engine
This is Rietveld 408576698