chrome/browser/ui/views/toolbar/toolbar_button.cc - Issue 2042073002: Centered flood fill style ink drop ripples on mouse/touch points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_button.cc

Issue 2042073002: Centered flood fill style ink drop ripples on mouse/touch points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved InkDropHostView::AsLocatedEvent() to event_utils.(h|cc) as ToLocatedEventOrNull(). Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/location_bar/icon_label_bubble_view.h ('K') | « chrome/browser/ui/views/toolbar/toolbar_action_view.cc ('k') | ui/events/event_utils.h » ('j') | ui/events/event_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/toolbar/toolbar_button.cc

diff --git a/chrome/browser/ui/views/toolbar/toolbar_button.cc b/chrome/browser/ui/views/toolbar/toolbar_button.cc

index 82a4f391e2685c6854abd75b387b9c39adc7ceed..52dc2f14437c47e70b7fb85ee3e23cde897bf1d6 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_button.cc

+++ b/chrome/browser/ui/views/toolbar/toolbar_button.cc

@@ -220,7 +220,7 @@ void ToolbarButton::ShowDropDownMenu(ui::MenuSourceType source_type) {

menu_showing_ = true;

- AnimateInkDrop(views::InkDropState::ACTIVATED);

+ AnimateInkDrop(views::InkDropState::ACTIVATED, nullptr /* event */);

// Exit if the model is null.

if (!model_.get())

@@ -240,7 +240,7 @@ void ToolbarButton::ShowDropDownMenu(ui::MenuSourceType source_type) {

}

void ToolbarButton::OnMenuClosed() {

- AnimateInkDrop(views::InkDropState::DEACTIVATED);

+ AnimateInkDrop(views::InkDropState::DEACTIVATED, nullptr /* event */);

menu_showing_ = false;