chrome/browser/ui/views/toolbar/toolbar_action_view.cc - Issue 2042073002: Centered flood fill style ink drop ripples on mouse/touch points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_action_view.cc

Issue 2042073002: Centered flood fill style ink drop ripples on mouse/touch points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved InkDropHostView::AsLocatedEvent() to event_utils.(h|cc) as ToLocatedEventOrNull(). Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/location_bar/icon_label_bubble_view.h ('K') | « chrome/browser/ui/views/location_bar/location_icon_view.cc ('k') | chrome/browser/ui/views/toolbar/toolbar_button.cc » ('j') | ui/events/event_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/toolbar/toolbar_action_view.cc

diff --git a/chrome/browser/ui/views/toolbar/toolbar_action_view.cc b/chrome/browser/ui/views/toolbar/toolbar_action_view.cc

index 50d6d27680a68c8f00d1b71a153d1ebe3af5a134..233deda69938dbd6635d1e57a04db4e9bcb2bccc 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_action_view.cc

+++ b/chrome/browser/ui/views/toolbar/toolbar_action_view.cc

@@ -190,7 +190,7 @@ bool ToolbarActionView::OnMousePressed(const ui::MouseEvent& event) {

// TODO(bruthig): The ACTION_PENDING triggering logic should be in

// MenuButton::OnPressed() however there is a bug with the pressed state

// logic in MenuButton. See http://crbug.com/567252.

- AnimateInkDrop(views::InkDropState::ACTION_PENDING);

+ AnimateInkDrop(views::InkDropState::ACTION_PENDING, &event);

}

return MenuButton::OnMousePressed(event);

}