chrome/browser/ui/views/location_bar/icon_label_bubble_view.h - Issue 2042073002: Centered flood fill style ink drop ripples on mouse/touch points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

Issue 2042073002: Centered flood fill style ink drop ripples on mouse/touch points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moved InkDropHostView::AsLocatedEvent() to event_utils.(h|cc) as ToLocatedEventOrNull(). Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/content_setting_image_view.cc ('k') | chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc » ('j') | ui/events/event_utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

diff --git a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

index 71d58816851f76b571b39da2b630c5dabf07ae57..e391bf0ffa2b737c1290202419cb09be3d9f64e7 100644

--- a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

+++ b/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

@@ -76,7 +76,7 @@ class IconLabelBubbleView : public views::InkDropHostView {

// The view has been activated by a user gesture such as spacebar. Returns

// true if some handling was performed.

- virtual bool OnActivate();

+ virtual bool OnActivate(const ui::Event* event);

sky 2016/06/16 16:50:02 Can this be a const ui::Event& ? AFAICT event is n

bruthig 2016/06/16 19:50:02 Done.

// views::View:

gfx::Size GetPreferredSize() const override;