Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 204143004: update bitmapshader to avoid potential rendering error for kA8_Config (Closed)

Created:
6 years, 9 months ago by yunchao
Modified:
6 years, 9 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

update bitmapshader to avoid potential rendering error for kA8_Config A local matrix is set to the shader, which will show the potential error for SkCanvas::drawBitmap when the bitmap is kA8_Config, as well as the potential error for drawing a geometry with a bitmapshader who's bitmap is kA8_Config. A simple case is also added for SkCanvas::drawBitmap when the bitmap is kA8_Config, but there is not shader. Then the drawing area will be colorized by the solid color set in SkPaint. BUG=skia:2278 BUG=skia:2293 Committed: http://code.google.com/p/skia/source/detail?r=13904

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : rebase code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -17 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M gm/bitmapshader.cpp View 1 2 chunks +38 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
yunchao
PTAL
6 years, 9 months ago (2014-03-19 06:45:23 UTC) #1
yunchao
On 2014/03/19 06:45:23, Richard Ho wrote: > PTAL Mike and Brian, any suggestion about this ...
6 years, 9 months ago (2014-03-21 14:50:28 UTC) #2
reed1
lgtm
6 years, 9 months ago (2014-03-21 16:01:30 UTC) #3
yunchao
The CQ bit was checked by yunchao.he@intel.com
6 years, 9 months ago (2014-03-22 13:59:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/yunchao.he@intel.com/204143004/40001
6 years, 9 months ago (2014-03-22 13:59:08 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-22 13:59:10 UTC) #6
commit-bot: I haz the power
Failed to apply patch for expectations/gm/ignored-tests.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 9 months ago (2014-03-22 13:59:11 UTC) #7
yunchao
The CQ bit was checked by yunchao.he@intel.com
6 years, 9 months ago (2014-03-24 02:33:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/yunchao.he@intel.com/204143004/80001
6 years, 9 months ago (2014-03-24 02:33:17 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-24 02:49:50 UTC) #10
Message was sent while issue was closed.
Change committed as 13904

Powered by Google App Engine
This is Rietveld 408576698