third_party/WebKit/Source/core/fileapi/FileReader.h - Issue 2040563002: Remove FileError interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fileapi/FileReader.h

Issue 2040563002: Remove FileError interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fe-dep

Patch Set: handleEvent -> invoke and other review nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fileapi/FileReader.h

diff --git a/third_party/WebKit/Source/core/fileapi/FileReader.h b/third_party/WebKit/Source/core/fileapi/FileReader.h

index de7bee0dfe91f8d980de860e12dee3da8b605063..c3e8598dbf6ec41501bb1470afefc59fe724e37e 100644

--- a/third_party/WebKit/Source/core/fileapi/FileReader.h

+++ b/third_party/WebKit/Source/core/fileapi/FileReader.h

@@ -73,7 +73,7 @@ public:

void doAbort();

ReadyState getReadyState() const { return m_state; }

- FileError* error() { return m_error; }

+ DOMException* error() { return m_error; }

void result(StringOrArrayBuffer& resultAttribute) const;

// ActiveDOMObject

@@ -130,7 +130,7 @@ private:

String m_encoding;

std::unique_ptr<FileReaderLoader> m_loader;

- Member<FileError> m_error;

+ Member<DOMException> m_error;

double m_lastProgressNotificationTimeMS;

};