third_party/WebKit/Source/core/fileapi/FileReader.cpp - Issue 2040563002: Remove FileError interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fileapi/FileReader.cpp

Issue 2040563002: Remove FileError interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fe-dep

Patch Set: handleEvent -> invoke and other review nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/fileapi/FileReader.cpp

diff --git a/third_party/WebKit/Source/core/fileapi/FileReader.cpp b/third_party/WebKit/Source/core/fileapi/FileReader.cpp

index 648352ed2addfc10b4b0a2af2b9286921e032568..f274d58f10ba4c54e8150f35fd6f809fdb2f9976 100644

--- a/third_party/WebKit/Source/core/fileapi/FileReader.cpp

+++ b/third_party/WebKit/Source/core/fileapi/FileReader.cpp

@@ -344,7 +344,7 @@ void FileReader::doAbort()

terminate();

- m_error = FileError::create(FileError::ABORT_ERR);

+ m_error = FileError::createDOMException(FileError::ABORT_ERR);

// Unregister the reader.

ThrottlingController::FinishReaderType finalStep = ThrottlingController::removeReader(getExecutionContext(), this);

@@ -431,7 +431,7 @@ void FileReader::didFail(FileError::ErrorCode errorCode)

ASSERT(m_state != DONE);

m_state = DONE;

- m_error = FileError::create(static_cast<FileError::ErrorCode>(errorCode));

+ m_error = FileError::createDOMException(static_cast<FileError::ErrorCode>(errorCode));

// Unregister the reader.

ThrottlingController::FinishReaderType finalStep = ThrottlingController::removeReader(getExecutionContext(), this);