Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js

Issue 2040563002: Remove FileError interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fe-dep
Patch Set: handleEvent -> invoke and other review nits Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js
index 4d318bab05e0b710ae813327a7a8a1675ac44803..96bd1e19e04fac75b416e2cfe321ac846f8cddd1 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js
@@ -214,14 +214,14 @@ WebInspector.TimelineLoader.prototype = {
*/
onError: function(reader, event)
{
- switch (event.target.error.code) {
- case FileError.NOT_FOUND_ERR:
+ switch (event.target.error.name) {
pfeldman 2016/07/12 21:29:44 Was name previously available? If not, you would n
jsbell 2016/07/13 16:55:07 Yes; FileError started inheriting from DOMError ci
+ case 'NotFoundError':
this._reportErrorAndCancelLoading(WebInspector.UIString("File \"%s\" not found.", reader.fileName()));
break;
- case FileError.NOT_READABLE_ERR:
+ case 'NotReadableError':
this._reportErrorAndCancelLoading(WebInspector.UIString("File \"%s\" is not readable", reader.fileName()));
break;
- case FileError.ABORT_ERR:
+ case 'AbortError':
break;
default:
this._reportErrorAndCancelLoading(WebInspector.UIString("An error occurred while reading the file \"%s\"", reader.fileName()));

Powered by Google App Engine
This is Rietveld 408576698