Move {Resolve|Reject}JavascriptCallback helpers in WebUIMessageHandler.

WebUI: Move {Resolve|Reject}JavascriptCallback helpers in WebUIMessageHandler.

cr.sendWithPromise() is gaining traction outside of MD Settings, and the
C++ helpers to resolve/reject a JS Promise are more useful in the
superclass WebUIMessageHandler instead of SettingsPageUIHandler.

Committed: https://crrev.com/4d3274eedb49b0e0dde4be245656253276cb2b1d
Cr-Commit-Position: refs/heads/master@{#398166}

[dpapad, 2016-06-03 16:51:45]

Description was changed from

==========
Move {Resolve|Reject}JavascriptCallback helpers in WebUIMessageHandler.

BUG=
==========

to

==========
WebUI: Move {Resolve|Reject}JavascriptCallback helpers in WebUIMessageHandler.

cr.sendWithPromise() is gaining traction outside of MD Settings, and the
C++ helpers to resolve/reject a JS Promise can are more useful in
WebUIMessageHandler instead of SettingsPageUIHandler.
==========

[dpapad, 2016-06-03 16:54:07]

Description was changed from

==========
WebUI: Move {Resolve|Reject}JavascriptCallback helpers in WebUIMessageHandler.

cr.sendWithPromise() is gaining traction outside of MD Settings, and the
C++ helpers to resolve/reject a JS Promise can are more useful in
WebUIMessageHandler instead of SettingsPageUIHandler.
==========

to

==========
WebUI: Move {Resolve|Reject}JavascriptCallback helpers in WebUIMessageHandler.

cr.sendWithPromise() is gaining traction outside of MD Settings, and the
C++ helpers to resolve/reject a JS Promise can are more useful in
WebUIMessageHandler instead of SettingsPageUIHandler.
==========

[dpapad, 2016-06-03 16:54:22]

Description was changed from

==========
WebUI: Move {Resolve|Reject}JavascriptCallback helpers in WebUIMessageHandler.

cr.sendWithPromise() is gaining traction outside of MD Settings, and the
C++ helpers to resolve/reject a JS Promise can are more useful in
WebUIMessageHandler instead of SettingsPageUIHandler.
==========

to

==========
WebUI: Move {Resolve|Reject}JavascriptCallback helpers in WebUIMessageHandler.

cr.sendWithPromise() is gaining traction outside of MD Settings, and the
C++ helpers to resolve/reject a JS Promise can are more useful in
the superclass WebUIMessageHandler instead of SettingsPageUIHandler.
==========

[dpapad, 2016-06-03 17:16:49]

Description was changed from

==========
WebUI: Move {Resolve|Reject}JavascriptCallback helpers in WebUIMessageHandler.

cr.sendWithPromise() is gaining traction outside of MD Settings, and the
C++ helpers to resolve/reject a JS Promise can are more useful in
the superclass WebUIMessageHandler instead of SettingsPageUIHandler.
==========

to

==========
WebUI: Move {Resolve|Reject}JavascriptCallback helpers in WebUIMessageHandler.

cr.sendWithPromise() is gaining traction outside of MD Settings, and the
C++ helpers to resolve/reject a JS Promise are more useful in the
superclass WebUIMessageHandler instead of SettingsPageUIHandler.
==========

[dpapad, 2016-06-03 18:55:13]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2016-06-03 18:55:14]

I had to call AllowJavascript() in a couple of places, because the old code was
using web_ui()->CallJavascriptFunction, so it was circumventing the JS related
checks.

[Dan Beam, 2016-06-03 19:03:36]

lgtm

https://codereview.chromium.org/2040473002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc
(right):

https://codereview.chromium.org/2040473002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc:83:
CHECK(args->GetString(0, &webui_callback_id_));
nit: maybe AllowJavascript() here?

[dpapad, 2016-06-03 19:41:13]

dpapad@chromium.org changed reviewers:
+ jochen@chromium.org

[dpapad, 2016-06-03 19:41:14]

+jochen for content/

https://codereview.chromium.org/2040473002/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc
(right):

https://codereview.chromium.org/2040473002/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc:83:
CHECK(args->GetString(0, &webui_callback_id_));
On 2016/06/03 at 19:03:36, Dan Beam wrote:
> nit: maybe AllowJavascript() here?

Done.

[dpapad, 2016-06-06 17:49:10]

On 2016/06/03 at 19:41:14, dpapad wrote:
> +jochen for content/
> 
>
https://codereview.chromium.org/2040473002/diff/40001/chrome/browser/ui/webui...
> File chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc
(right):
> 
>
https://codereview.chromium.org/2040473002/diff/40001/chrome/browser/ui/webui...
> chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc:83:
CHECK(args->GetString(0, &webui_callback_id_));
> On 2016/06/03 at 19:03:36, Dan Beam wrote:
> > nit: maybe AllowJavascript() here?
> 
> Done.

@jochen: Friendly ping.

[dpapad, 2016-06-06 21:05:23]

dpapad@chromium.org changed reviewers:
+ creis@chromium.org

[dpapad, 2016-06-06 21:05:24]

+creis for content/public/

[Charlie Reis, 2016-06-06 21:19:52]

Seems ok.  LGTM with some clarifications about what cr is.

https://codereview.chromium.org/2040473002/diff/60001/content/public/browser/...
File content/public/browser/web_ui_message_handler.h (right):

https://codereview.chromium.org/2040473002/diff/60001/content/public/browser/...
content/public/browser/web_ui_message_handler.h:80: // Helper method for
responding to JS requests initiated with
nit: Javascript

https://codereview.chromium.org/2040473002/diff/60001/content/public/browser/...
content/public/browser/web_ui_message_handler.h:81: // cr.sendWithPromise(), for
the case where the returned promise should be
What is cr?

https://codereview.chromium.org/2040473002/diff/60001/content/public/browser/...
content/public/browser/web_ui_message_handler.h:86: // Helper method for
responding to JS requests initiated with
(Same comments)

[dpapad, 2016-06-06 21:28:53]

Thanks!

https://codereview.chromium.org/2040473002/diff/60001/content/public/browser/...
File content/public/browser/web_ui_message_handler.h (right):

https://codereview.chromium.org/2040473002/diff/60001/content/public/browser/...
content/public/browser/web_ui_message_handler.h:80: // Helper method for
responding to JS requests initiated with
On 2016/06/06 at 21:19:52, Charlie Reis wrote:
> nit: Javascript

Done.

https://codereview.chromium.org/2040473002/diff/60001/content/public/browser/...
content/public/browser/web_ui_message_handler.h:81: // cr.sendWithPromise(), for
the case where the returned promise should be
On 2016/06/06 at 21:19:52, Charlie Reis wrote:
> What is cr?

'cr' is simply a namespace used by cr.js (where the sendWithPromise function is
defined), such that the global namespace (window) is not polluted. I added a
comment to that effect.

https://codereview.chromium.org/2040473002/diff/60001/content/public/browser/...
content/public/browser/web_ui_message_handler.h:86: // Helper method for
responding to JS requests initiated with
On 2016/06/06 at 21:19:52, Charlie Reis wrote:
> (Same comments)

Done. See previous comment.

[dpapad, 2016-06-06 21:36:51]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-06-06 21:36:52]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org,
creis@chromium.org
Link to the patchset: https://codereview.chromium.org/2040473002/#ps80001
(title: "Address comment.")

[commit-bot: I haz the power, 2016-06-06 21:37:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040473002/80001

[commit-bot: I haz the power, 2016-06-06 21:39:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 21:39:37]

Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[dpapad, 2016-06-06 21:55:09]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-06-06 21:55:10]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org,
dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2040473002/#ps100001
(title: "Resolvig conflicts with ToT")

[commit-bot: I haz the power, 2016-06-06 21:55:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2040473002/100001

[commit-bot: I haz the power, 2016-06-07 00:15:49]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-07 00:18:07]

Description was changed from

==========
WebUI: Move {Resolve|Reject}JavascriptCallback helpers in WebUIMessageHandler.

cr.sendWithPromise() is gaining traction outside of MD Settings, and the
C++ helpers to resolve/reject a JS Promise are more useful in the
superclass WebUIMessageHandler instead of SettingsPageUIHandler.
==========

to

==========
WebUI: Move {Resolve|Reject}JavascriptCallback helpers in WebUIMessageHandler.

cr.sendWithPromise() is gaining traction outside of MD Settings, and the
C++ helpers to resolve/reject a JS Promise are more useful in the
superclass WebUIMessageHandler instead of SettingsPageUIHandler.

Committed: https://crrev.com/4d3274eedb49b0e0dde4be245656253276cb2b1d
Cr-Commit-Position: refs/heads/master@{#398166}
==========

[commit-bot: I haz the power, 2016-06-07 00:18:09]

Patchset 6 (id:??) landed as
https://crrev.com/4d3274eedb49b0e0dde4be245656253276cb2b1d
Cr-Commit-Position: refs/heads/master@{#398166}