Move {Resolve|Reject}JavascriptCallback helpers in WebUIMessageHandler.

content/public/browser/web_ui_message_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_UI_MESSAGE_HANDLER_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_UI_MESSAGE_HANDLER_H_
 
 #include <vector>
 
 #include "base/gtest_prod_util.h"
@@ skipping 59 matching lines @@
   // the disallowed state. Subclasses should override this method to register
   // observers that push JavaScript calls to the page.
   virtual void OnJavascriptAllowed() {}
 
   // Will be called whenever JavaScript from this handler becomes disallowed
   // from the allowed state. This will never be called before
   // OnJavascriptAllowed has been called. Subclasses should override this method
   // to deregister or disabled observers that push JavaScript calls to the page.
   virtual void OnJavascriptDisallowed() {}
 
+  // Helper method for responding to JS requests initiated with

[Charlie Reis, 2016/06/06 21:19:52]

nit: Javascript

[dpapad, 2016/06/06 21:28:53]

Done.

+  // cr.sendWithPromise(), for the case where the returned promise should be

[Charlie Reis, 2016/06/06 21:19:52]

What is cr?

[dpapad, 2016/06/06 21:28:53]

'cr' is simply a namespace used by cr.js (where the sendWithPromise function is
defined), such that the global namespace (window) is not polluted. I added a
comment to that effect.

+  // resolved (request succeeded).
+  void ResolveJavascriptCallback(const base::Value& callback_id,
+                                 const base::Value& response);
+
+  // Helper method for responding to JS requests initiated with

[Charlie Reis, 2016/06/06 21:19:52]

(Same comments)

[dpapad, 2016/06/06 21:28:53]

Done. See previous comment.

+  // cr.sendWithPromise(), for the case where the returned promise should be
+  // rejected (request failed).
+  void RejectJavascriptCallback(const base::Value& callback_id,
+                                const base::Value& response);
+
   // Call a Javascript function by sending its name and arguments down to
   // the renderer.  This is asynchronous; there's no way to get the result
   // of the call, and should be thought of more like sending a message to
   // the page.
   // All function names in WebUI must consist of only ASCII characters.
   // These functions will crash if JavaScript is not currently allowed.
   template <typename... Values>
   void CallJavascriptFunction(const std::string& function_name,
                               const Values&... values) {
     CHECK(IsJavascriptAllowed()) << "Cannot CallJavascriptFunction before "
@@ skipping 21 matching lines @@
 
   // True if the page is for JavaScript calls from this handler.
   bool javascript_allowed_;
 
   WebUI* web_ui_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_UI_MESSAGE_HANDLER_H_