chrome/browser/ui/webui/signin/user_manager_screen_handler.cc - Issue 2040473002: Move {Resolve|Reject}JavascriptCallback helpers in WebUIMessageHandler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/user_manager_screen_handler.cc

Issue 2040473002: Move {Resolve|Reject}JavascriptCallback helpers in WebUIMessageHandler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolvig conflicts with ToT Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc ('k') | content/browser/webui/web_ui_message_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/signin/user_manager_screen_handler.cc

diff --git a/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc b/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc

index c2850274668d202bb372f5d45ff9c805e8633675..9562da076662b2035c6d9b7f44dbd9c1fb0b67cf 100644

--- a/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc

+++ b/chrome/browser/ui/webui/signin/user_manager_screen_handler.cc

@@ -502,9 +502,9 @@ void UserManagerScreenHandler::HandleAreAllProfilesLocked(

bool success = args->GetString(0, &webui_callback_id);

DCHECK(success);

- web_ui()->CallJavascriptFunctionUnsafe(

- "cr.webUIResponse", base::StringValue(webui_callback_id),

- base::FundamentalValue(true),

+ AllowJavascript();

+ ResolveJavascriptCallback(

+ base::StringValue(webui_callback_id),

base::FundamentalValue(profiles::AreAllProfilesLocked()));

}