Move ScopedIPCSupport into its own build rule.

Move ScopedIPCSupport into its own build rule.

BUG=604282
TBR=lhchavez@chromium.org,scottmg@chromium.org

Committed: https://crrev.com/191f7c6722124ac77cb14beb6e9f11de84349526
Cr-Commit-Position: refs/heads/master@{#399809}

[Anand Mistry (off Chromium), 2016-06-14 00:54:36]

amistry@chromium.org changed reviewers:
+ rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-06-14 02:31:26]

lgtm

https://codereview.chromium.org/2049363002/diff/40001/ipc/mojo/BUILD.gn
File ipc/mojo/BUILD.gn (right):

https://codereview.chromium.org/2049363002/diff/40001/ipc/mojo/BUILD.gn#newco...
ipc/mojo/BUILD.gn:42: source_set("mojo_support") {
nit: I kinda think "ipc_support" would be a more palatable name for this.
"//ipc/mojo:ipc_support" sufficiently conveys that it's mojo IPC support whereas
"//ipc/mojo:mojo_support" seems a bit (more) redundant.

[Anand Mistry (off Chromium), 2016-06-14 03:57:16]

amistry@chromium.org changed reviewers:
+ sievers@chromium.org

[Anand Mistry (off Chromium), 2016-06-14 03:57:17]

sievers@chromium.org: For content/ build files.

https://codereview.chromium.org/2049363002/diff/40001/ipc/mojo/BUILD.gn
File ipc/mojo/BUILD.gn (right):

https://codereview.chromium.org/2049363002/diff/40001/ipc/mojo/BUILD.gn#newco...
ipc/mojo/BUILD.gn:42: source_set("mojo_support") {
On 2016/06/14 02:31:26, Ken Rockot wrote:
> nit: I kinda think "ipc_support" would be a more palatable name for this.
> "//ipc/mojo:ipc_support" sufficiently conveys that it's mojo IPC support
whereas
> "//ipc/mojo:mojo_support" seems a bit (more) redundant.

Done, but only for gn. gyp has it's own naming weirdness.

[no sievers, 2016-06-14 18:14:13]

lgtm

[Anand Mistry (off Chromium), 2016-06-15 00:00:09]

Description was changed from

==========
Move ScopedIPCSupport into its own build rule.

BUG=604282
==========

to

==========
Move ScopedIPCSupport into its own build rule.

BUG=604282
TBR=lhchavez@chromium.org,scottmg@chromium.org
==========

[Anand Mistry (off Chromium), 2016-06-15 00:01:14]

TBRing:
lhchavez for unnecessary include removal in arc
scottmg for trivial build rule changes in tools

[Anand Mistry (off Chromium), 2016-06-15 00:01:22]

The CQ bit was checked by amistry@chromium.org

[Anand Mistry (off Chromium), 2016-06-15 00:01:22]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2049363002/#ps60001
(title: "change rule name")

[commit-bot: I haz the power, 2016-06-15 00:01:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2049363002/60001

[Luis Héctor Chávez, 2016-06-15 00:02:39]

lhchavez@chromium.org changed reviewers:
+ lhchavez@chromium.org

[Luis Héctor Chávez, 2016-06-15 00:02:39]

lgtm. sorry I missed removing that in a previous change.

[scottmg, 2016-06-15 00:06:41]

scottmg@chromium.org changed reviewers:
+ scottmg@chromium.org

[scottmg, 2016-06-15 00:06:42]

tools lgtm

[commit-bot: I haz the power, 2016-06-15 01:07:14]

Description was changed from

==========
Move ScopedIPCSupport into its own build rule.

BUG=604282
TBR=lhchavez@chromium.org,scottmg@chromium.org
==========

to

==========
Move ScopedIPCSupport into its own build rule.

BUG=604282
TBR=lhchavez@chromium.org,scottmg@chromium.org
==========

[commit-bot: I haz the power, 2016-06-15 01:07:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-15 01:07:31]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-15 01:09:05]

Description was changed from

==========
Move ScopedIPCSupport into its own build rule.

BUG=604282
TBR=lhchavez@chromium.org,scottmg@chromium.org
==========

to

==========
Move ScopedIPCSupport into its own build rule.

BUG=604282
TBR=lhchavez@chromium.org,scottmg@chromium.org

Committed: https://crrev.com/191f7c6722124ac77cb14beb6e9f11de84349526
Cr-Commit-Position: refs/heads/master@{#399809}
==========

[commit-bot: I haz the power, 2016-06-15 01:09:07]

Patchset 4 (id:??) landed as
https://crrev.com/191f7c6722124ac77cb14beb6e9f11de84349526
Cr-Commit-Position: refs/heads/master@{#399809}