Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Side by Side Diff: src/api-arguments.cc

Issue 2039913002: Make api-arguments.h not include inline headers. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_cleanup-includes-type-feedback-vector
Patch Set: Addressed comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/api-arguments.h ('k') | src/api-arguments-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/api-arguments.h" 5 #include "src/api-arguments.h"
6 6
7 #include "src/tracing/trace-event.h"
8 #include "src/vm-state-inl.h"
9
7 namespace v8 { 10 namespace v8 {
8 namespace internal { 11 namespace internal {
9 12
10 Handle<Object> FunctionCallbackArguments::Call(FunctionCallback f) { 13 Handle<Object> FunctionCallbackArguments::Call(FunctionCallback f) {
11 Isolate* isolate = this->isolate(); 14 Isolate* isolate = this->isolate();
12 RuntimeCallTimerScope timer(isolate, &RuntimeCallStats::FunctionCallback); 15 RuntimeCallTimerScope timer(isolate, &RuntimeCallStats::FunctionCallback);
13 VMState<EXTERNAL> state(isolate); 16 VMState<EXTERNAL> state(isolate);
14 ExternalCallbackScope call_scope(isolate, FUNCTION_ADDR(f)); 17 ExternalCallbackScope call_scope(isolate, FUNCTION_ADDR(f));
15 FunctionCallbackInfo<v8::Value> info(begin(), argv_, argc_); 18 FunctionCallbackInfo<v8::Value> info(begin(), argv_, argc_);
16 f(info); 19 f(info);
17 return GetReturnValue<Object>(isolate); 20 return GetReturnValue<Object>(isolate);
18 } 21 }
19 22
20 Handle<JSObject> PropertyCallbackArguments::Call( 23 Handle<JSObject> PropertyCallbackArguments::Call(
21 IndexedPropertyEnumeratorCallback f) { 24 IndexedPropertyEnumeratorCallback f) {
22 Isolate* isolate = this->isolate(); 25 Isolate* isolate = this->isolate();
23 RuntimeCallTimerScope timer(isolate, &RuntimeCallStats::PropertyCallback); 26 RuntimeCallTimerScope timer(isolate, &RuntimeCallStats::PropertyCallback);
24 VMState<EXTERNAL> state(isolate); 27 VMState<EXTERNAL> state(isolate);
25 ExternalCallbackScope call_scope(isolate, FUNCTION_ADDR(f)); 28 ExternalCallbackScope call_scope(isolate, FUNCTION_ADDR(f));
26 PropertyCallbackInfo<v8::Array> info(begin()); 29 PropertyCallbackInfo<v8::Array> info(begin());
27 f(info); 30 f(info);
28 return GetReturnValue<JSObject>(isolate); 31 return GetReturnValue<JSObject>(isolate);
29 } 32 }
30 33
31 } // namespace internal 34 } // namespace internal
32 } // namespace v8 35 } // namespace v8
OLDNEW
« no previous file with comments | « src/api-arguments.h ('k') | src/api-arguments-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698