Add format modifier IDs for EGL_EXT_image_dma_buf_import extension

ui/gl/gl_image_ozone_native_pixmap.cc

Index: ui/gl/gl_image_ozone_native_pixmap.cc
diff --git a/ui/gl/gl_image_ozone_native_pixmap.cc b/ui/gl/gl_image_ozone_native_pixmap.cc
index 977f02e424ff06f389098e1a4094bc4dfa6da31a..72eb1ce2a707b04d655dd753bc9ec944df02c041 100644
--- a/ui/gl/gl_image_ozone_native_pixmap.cc
+++ b/ui/gl/gl_image_ozone_native_pixmap.cc
@@ -140,6 +140,7 @@ bool GLImageOzoneNativePixmap::Initialize(ui::NativePixmap* pixmap,
     for (size_t plane = 0;
          plane < gfx::NumberOfPlanesForBufferFormat(pixmap->GetBufferFormat());
          ++plane) {
+      uint64_t modifier = pixmap->GetDmaBufModifier(plane);
       attrs.push_back(EGL_DMA_BUF_PLANE0_FD_EXT + plane * 3);
       attrs.push_back(
           pixmap->GetDmaBufFd(plane < pixmap->GetDmaBufFdCount() ? plane : 0));
@@ -147,6 +148,10 @@ bool GLImageOzoneNativePixmap::Initialize(ui::NativePixmap* pixmap,
       attrs.push_back(pixmap->GetDmaBufOffset(plane));
       attrs.push_back(EGL_DMA_BUF_PLANE0_PITCH_EXT + plane * 3);
       attrs.push_back(pixmap->GetDmaBufPitch(plane));
+      attrs.push_back(EGL_LINUX_DRM_PLANE0_MODIFIER0_EXT + plane * 3);

[Daniele Castagna, 2016/06/15 17:30:10]

Is this working as intended?

for plane = 1 we pass EGL_LINUX_DRM_PLANE0_MODIFIER0_EXT + 3, that is
EGL_LINUX_DRM_PLANE1_MODIFIER1_EXT, while I'd expect it to be
EGL_LINUX_DRM_PLANE1_MODIFIER0_EXT.

What am I missing?

[vinceh, 2016/06/16 02:08:44]

You're right. That's my mistake. I should have it as "plane * 2" for
EGL_LINUX_DRM_PLANE0_MODIFIER0_EXT. I did not find any issue with it because we
only used one plane. Will fix it. Thanks for catching this.

+      attrs.push_back(modifier & 0xffffffff);
+      attrs.push_back(EGL_LINUX_DRM_PLANE0_MODIFIER1_EXT + plane * 3);
+      attrs.push_back(static_cast<uint32_t>(modifier >> 32));
     }
     attrs.push_back(EGL_NONE);