Add format modifier IDs for EGL_EXT_image_dma_buf_import extension

ui/gl/gl_image_ozone_native_pixmap.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/buffer_format_util.h"
 #include "ui/gl/gl_image_ozone_native_pixmap.h"
 
 #define FOURCC(a, b, c, d)                                        \
   ((static_cast<uint32_t>(a)) | (static_cast<uint32_t>(b) << 8) | \
    (static_cast<uint32_t>(c) << 16) | (static_cast<uint32_t>(d) << 24))
@@ skipping 122 matching lines @@
     attrs.push_back(EGL_WIDTH);
     attrs.push_back(size_.width());
     attrs.push_back(EGL_HEIGHT);
     attrs.push_back(size_.height());
     attrs.push_back(EGL_LINUX_DRM_FOURCC_EXT);
     attrs.push_back(FourCC(format));
 
     for (size_t plane = 0;
          plane < gfx::NumberOfPlanesForBufferFormat(pixmap->GetBufferFormat());
          ++plane) {
+      uint64_t modifier = pixmap->GetDmaBufModifier(plane);
       attrs.push_back(EGL_DMA_BUF_PLANE0_FD_EXT + plane * 3);
       attrs.push_back(
           pixmap->GetDmaBufFd(plane < pixmap->GetDmaBufFdCount() ? plane : 0));
       attrs.push_back(EGL_DMA_BUF_PLANE0_OFFSET_EXT + plane * 3);
       attrs.push_back(pixmap->GetDmaBufOffset(plane));
       attrs.push_back(EGL_DMA_BUF_PLANE0_PITCH_EXT + plane * 3);
       attrs.push_back(pixmap->GetDmaBufPitch(plane));
+      attrs.push_back(EGL_LINUX_DRM_PLANE0_MODIFIER0_EXT + plane * 3);

[Daniele Castagna, 2016/06/15 17:30:10]

Is this working as intended?

for plane = 1 we pass EGL_LINUX_DRM_PLANE0_MODIFIER0_EXT + 3, that is
EGL_LINUX_DRM_PLANE1_MODIFIER1_EXT, while I'd expect it to be
EGL_LINUX_DRM_PLANE1_MODIFIER0_EXT.

What am I missing?

[vinceh, 2016/06/16 02:08:44]

You're right. That's my mistake. I should have it as "plane * 2" for
EGL_LINUX_DRM_PLANE0_MODIFIER0_EXT. I did not find any issue with it because we
only used one plane. Will fix it. Thanks for catching this.

+      attrs.push_back(modifier & 0xffffffff);
+      attrs.push_back(EGL_LINUX_DRM_PLANE0_MODIFIER1_EXT + plane * 3);
+      attrs.push_back(static_cast<uint32_t>(modifier >> 32));
     }
     attrs.push_back(EGL_NONE);
 
     if (!GLImageEGL::Initialize(EGL_LINUX_DMA_BUF_EXT,
                                 static_cast<EGLClientBuffer>(nullptr),
                                 &attrs[0])) {
       return false;
     }
   }
 
@@ skipping 66 matching lines @@
     case gfx::BufferFormat::UYVY_422:
       NOTREACHED();
       return GL_NONE;
   }
 
   NOTREACHED();
   return GL_NONE;
 }
 
 }  // namespace gl