Chromium Code Reviews| Index: ui/gfx/native_pixmap_handle_ozone.h |
| diff --git a/ui/gfx/native_pixmap_handle_ozone.h b/ui/gfx/native_pixmap_handle_ozone.h |
| index 3672feca1cab3bac6d9e7dd2676353ff488e821d..92b8bc5daffd5b572fe4c65ebd8adb1049d55857 100644 |
| --- a/ui/gfx/native_pixmap_handle_ozone.h |
| +++ b/ui/gfx/native_pixmap_handle_ozone.h |
| @@ -13,6 +13,24 @@ |
| namespace gfx { |
| +// GbmBufferPlane is used to carry the plane related information for GBM |
| +// buffer. More fields can be added if they are plane specific. |
| +struct GFX_EXPORT GbmBufferPlane { |
| + GbmBufferPlane(); |
| + GbmBufferPlane(int stride, int offset, uint64_t modifier); |
| + GbmBufferPlane(const GbmBufferPlane& other); |
| + ~GbmBufferPlane(); |
| + |
| + // The strides and offsets in bytes to be used when accessing the buffers via |
| + // a memory mapping. One per plane per entry. |
| + int stride; |
| + int offset; |
| + // The modifiers is retrieved from GBM library and passed to EGL driver. |
|
Daniele Castagna
2016/06/15 17:30:09
nit: s/modifiers/modifier or make the verb plural.
vinceh
2016/06/16 02:08:44
Oops. Will fix.
|
| + // Generally it's platform specific, and we don't need to modify it in |
| + // browser code. Also one per plane per entry. |
|
Daniele Castagna
2016/06/15 17:30:09
nit: if you use the term browser in chromium, we p
vinceh
2016/06/16 02:08:44
Yes, will fix.
|
| + uint64_t modifier; |
| +}; |
| + |
| struct GFX_EXPORT NativePixmapHandle { |
| NativePixmapHandle(); |
| NativePixmapHandle(const NativePixmapHandle& other); |
| @@ -21,9 +39,7 @@ struct GFX_EXPORT NativePixmapHandle { |
| // File descriptors for the underlying memory objects (usually dmabufs). |
| std::vector<base::FileDescriptor> fds; |
| - // The strides and offsets in bytes to be used when accessing the buffers via |
| - // a memory mapping. One per plane per entry. |
| - std::vector<std::pair<int, int>> strides_and_offsets; |
| + std::vector<GbmBufferPlane> planes; |
| }; |
| } // namespace gfx |