Wait for correct callback in CustomTabActivityTestBase

Wait for correct callback in CustomTabActivityTestBase

CustomTabActivityTestBase.startCustomTabActivityWithIntent should
check for onLoadStopped callbacks after verifying that
Tab.isLoading, since it is the only guaranteed callback.

BUG=618064
Committed: https://crrev.com/60a4046fb976a0dba8a2aeafcfeacdc8fe6e6f8f
Cr-Commit-Position: refs/heads/master@{#398553}

[kraush, 2016-06-07 20:21:02]

kraush@amazon.com changed reviewers:
+ pasko@chromium.org

[kraush, 2016-06-07 20:21:02]

Hi pasko,

Can you please take a look at this test fix? :)

Thanks!
Holger

[pasko, 2016-06-08 12:09:41]

The CQ bit was checked by pasko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-08 12:09:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2039773006/1

[pasko, 2016-06-08 12:20:20]

Description was changed from

==========
Wait for correct callback in CustomTabActivityTestBase

CustomTabActivityTestBase.startCustomTabActivityWithIntent should
check for onLoadStopped callbacks after verifying that
Tab.isLoading, since it is the only guaranteed callback.

BUG=618064
==========

to

==========
Wait for correct callback in CustomTabActivityTestBase

CustomTabActivityTestBase.startCustomTabActivityWithIntent should
check for onLoadStopped callbacks after verifying that
Tab.isLoading, since it is the only guaranteed callback.

BUG=618064
==========

[pasko, 2016-06-08 12:20:20]

pasko@chromium.org changed reviewers:
+ yusufo@chromium.org

[pasko, 2016-06-08 12:23:57]

lgtm, looks safer indeed

Adding Yusuf as FYI since he introduced this piece here:
https://codereview.chromium.org/1278473005

[commit-bot: I haz the power, 2016-06-08 12:55:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 12:55:19]

Dry run: This issue passed the CQ dry run.

[kraush, 2016-06-08 14:52:04]

The CQ bit was checked by kraush@amazon.com

[commit-bot: I haz the power, 2016-06-08 14:52:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2039773006/1

[commit-bot: I haz the power, 2016-06-08 14:56:29]

Description was changed from

==========
Wait for correct callback in CustomTabActivityTestBase

CustomTabActivityTestBase.startCustomTabActivityWithIntent should
check for onLoadStopped callbacks after verifying that
Tab.isLoading, since it is the only guaranteed callback.

BUG=618064
==========

to

==========
Wait for correct callback in CustomTabActivityTestBase

CustomTabActivityTestBase.startCustomTabActivityWithIntent should
check for onLoadStopped callbacks after verifying that
Tab.isLoading, since it is the only guaranteed callback.

BUG=618064
==========

[commit-bot: I haz the power, 2016-06-08 14:56:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-08 14:57:34]

Description was changed from

==========
Wait for correct callback in CustomTabActivityTestBase

CustomTabActivityTestBase.startCustomTabActivityWithIntent should
check for onLoadStopped callbacks after verifying that
Tab.isLoading, since it is the only guaranteed callback.

BUG=618064
==========

to

==========
Wait for correct callback in CustomTabActivityTestBase

CustomTabActivityTestBase.startCustomTabActivityWithIntent should
check for onLoadStopped callbacks after verifying that
Tab.isLoading, since it is the only guaranteed callback.

BUG=618064

Committed: https://crrev.com/60a4046fb976a0dba8a2aeafcfeacdc8fe6e6f8f
Cr-Commit-Position: refs/heads/master@{#398553}
==========

[commit-bot: I haz the power, 2016-06-08 14:57:35]

Patchset 1 (id:??) landed as
https://crrev.com/60a4046fb976a0dba8a2aeafcfeacdc8fe6e6f8f
Cr-Commit-Position: refs/heads/master@{#398553}