chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java - Issue 2039773006: Wait for correct callback in CustomTabActivityTestBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java

Issue 2039773006: Wait for correct callback in CustomTabActivityTestBase (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java

index 0f690d719a5b4766051506001d45afccf5f06bc0..48f85f60a4a89fb8fde9795755ad2207721aac3d 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTestBase.java

@@ -61,7 +61,7 @@ public abstract class CustomTabActivityTestBase extends

final CallbackHelper pageLoadFinishedHelper = new CallbackHelper();

tab.addObserver(new EmptyTabObserver() {

@Override

- public void onPageLoadFinished(Tab tab) {

+ public void onLoadStopped(Tab tab, boolean toDifferentDocument) {

pageLoadFinishedHelper.notifyCalled();

}

});

« no previous file with comments | « no previous file | no next file » | no next file with comments »