Add support in Chrome to send notifications to a specific device.

Add support in Chrome to send notifications to a specific device.

This CL adds the Chrome side support for sending notications to a specific
device as well as specifying whether an indiciation or notification should
be used.

Reviews requested:

xiyuan@ - general review
scheib@ - owner's review for the tests

R=scheib@chromium.org, xiyuan@chromium.org
BUG=617745
Committed: https://crrev.com/29d3f15b5d1e6e99da160f46e29231c68e5f3938
Cr-Commit-Position: refs/heads/master@{#399475}

[xiyuan, 2016-06-06 21:49:30]

lgtm

https://codereview.chromium.org/2039773005/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_local_gatt_characteristic_unittest.cc (right):

https://codereview.chromium.org/2039773005/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_local_gatt_characteristic_unittest.cc:56:
std::get<0>(actual_notification));
nit: #include <tuple> ?

[scheib, 2016-06-07 05:10:04]

Tests look OK, but please:

https://codereview.chromium.org/2039773005/diff/1/device/bluetooth/test/bluet...
File device/bluetooth/test/bluetooth_test.h (right):

https://codereview.chromium.org/2039773005/diff/1/device/bluetooth/test/bluet...
device/bluetooth/test/bluetooth_test.h:46: using NotificationType =
std::tuple<std::string, std::vector<uint8_t>, bool>;
Please use a struct with named members instead of the tuple.

[rkc, 2016-06-09 21:08:27]

https://codereview.chromium.org/2039773005/diff/1/device/bluetooth/bluetooth_...
File device/bluetooth/bluetooth_local_gatt_characteristic_unittest.cc (right):

https://codereview.chromium.org/2039773005/diff/1/device/bluetooth/bluetooth_...
device/bluetooth/bluetooth_local_gatt_characteristic_unittest.cc:56:
std::get<0>(actual_notification));
On 2016/06/06 21:49:29, xiyuan wrote:
> nit: #include <tuple> ?

Done.

https://codereview.chromium.org/2039773005/diff/1/device/bluetooth/test/bluet...
File device/bluetooth/test/bluetooth_test.h (right):

https://codereview.chromium.org/2039773005/diff/1/device/bluetooth/test/bluet...
device/bluetooth/test/bluetooth_test.h:46: using NotificationType =
std::tuple<std::string, std::vector<uint8_t>, bool>;
On 2016/06/07 05:10:04, scheib wrote:
> Please use a struct with named members instead of the tuple.

Using a struct raises several complications.
First, since this has complex types, the struct now will need to have a out of
line constructor, destructor and copy-constructor. Second, this means that we
need to mirror not just this one line between the fake implementation and here
but rather the declaration and implementation of the structure. Looking at all
of these factors, just using a tuple in the tests seemed like a simpler
solution.

[scheib, 2016-06-09 21:34:35]

https://codereview.chromium.org/2039773005/diff/1/device/bluetooth/test/bluet...
File device/bluetooth/test/bluetooth_test.h (right):

https://codereview.chromium.org/2039773005/diff/1/device/bluetooth/test/bluet...
device/bluetooth/test/bluetooth_test.h:46: using NotificationType =
std::tuple<std::string, std::vector<uint8_t>, bool>;
On 2016/06/09 21:08:27, rkc wrote:
> On 2016/06/07 05:10:04, scheib wrote:
> > Please use a struct with named members instead of the tuple.
> 
> Using a struct raises several complications.
> First, since this has complex types, the struct now will need to have a out of
> line constructor, destructor and copy-constructor. Second, this means that we
> need to mirror not just this one line between the fake implementation and here
> but rather the declaration and implementation of the structure. Looking at all
> of these factors, just using a tuple in the tests seemed like a simpler
> solution.

If not a struct, then named parameters to the methods. The fake can have three
named members. "std::get<1>(value), std::get<2>(value)" style code has poor
readability.

[rkc, 2016-06-12 00:24:28]

https://codereview.chromium.org/2039773005/diff/1/device/bluetooth/test/bluet...
File device/bluetooth/test/bluetooth_test.h (right):

https://codereview.chromium.org/2039773005/diff/1/device/bluetooth/test/bluet...
device/bluetooth/test/bluetooth_test.h:46: using NotificationType =
std::tuple<std::string, std::vector<uint8_t>, bool>;
On 2016/06/09 21:34:35, scheib wrote:
> On 2016/06/09 21:08:27, rkc wrote:
> > On 2016/06/07 05:10:04, scheib wrote:
> > > Please use a struct with named members instead of the tuple.
> > 
> > Using a struct raises several complications.
> > First, since this has complex types, the struct now will need to have a out
of
> > line constructor, destructor and copy-constructor. Second, this means that
we
> > need to mirror not just this one line between the fake implementation and
here
> > but rather the declaration and implementation of the structure. Looking at
all
> > of these factors, just using a tuple in the tests seemed like a simpler
> > solution.
> 
> If not a struct, then named parameters to the methods. The fake can have three
> named members. "std::get<1>(value), std::get<2>(value)" style code has poor
> readability.

Done.

[scheib, 2016-06-13 06:44:14]

LGTM

[rkc, 2016-06-13 16:17:39]

The CQ bit was checked by rkc@chromium.org

[rkc, 2016-06-13 16:17:40]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2039773005/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-06-13 16:18:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2039773005/40001

[commit-bot: I haz the power, 2016-06-13 17:43:05]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-13 17:43:23]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-13 17:44:34]

Description was changed from

==========
Add support in Chrome to send notifications to a specific device.

This CL adds the Chrome side support for sending notications to a specific
device as well as specifying whether an indiciation or notification should
be used.

Reviews requested:

xiyuan@ - general review
scheib@ - owner's review for the tests

R=scheib@chromium.org, xiyuan@chromium.org
BUG=617745
==========

to

==========
Add support in Chrome to send notifications to a specific device.

This CL adds the Chrome side support for sending notications to a specific
device as well as specifying whether an indiciation or notification should
be used.

Reviews requested:

xiyuan@ - general review
scheib@ - owner's review for the tests

R=scheib@chromium.org, xiyuan@chromium.org
BUG=617745

Committed: https://crrev.com/29d3f15b5d1e6e99da160f46e29231c68e5f3938
Cr-Commit-Position: refs/heads/master@{#399475}
==========

[commit-bot: I haz the power, 2016-06-13 17:44:35]

Patchset 3 (id:??) landed as
https://crrev.com/29d3f15b5d1e6e99da160f46e29231c68e5f3938
Cr-Commit-Position: refs/heads/master@{#399475}

[rkc, 2016-06-16 00:04:33]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2076433002/ by rkc@chromium.org.

The reason for reverting is: Original bug is not WontFix.
.