device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider.h - Issue 2039773005: Add support in Chrome to send notifications to a specific device.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider.h

Issue 2039773005: Add support in Chrome to send notifications to a specific device. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/dbus/bluetooth_gatt_application_service_provider_unittest.cc ('k') | device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider.h

diff --git a/device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider.h b/device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider.h

index 041467e6813396a876f4db59a93fcd7553eba48d..e67a4af7234e703271d9de65075493cc76c05dd3 100644

--- a/device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider.h

+++ b/device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider.h

@@ -38,7 +38,9 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothGattCharacteristicServiceProvider {

// Send a PropertyChanged signal to notify the Bluetooth daemon that the value

// of the "Value" property has changed to |value|.

- virtual void SendValueChanged(const std::vector<uint8_t>& value) = 0;

+ virtual void SendValueChanged(const dbus::ObjectPath& device_path,

+ const std::vector<uint8_t>& value,

+ bool indicate) = 0;

// Writes the characteristics's properties into the provided writer. If

// value is not null, it is written also, otherwise no value property is