device/bluetooth/dbus/bluetooth_gatt_application_service_provider_unittest.cc - Issue 2039773005: Add support in Chrome to send notifications to a specific device.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/dbus/bluetooth_gatt_application_service_provider_unittest.cc

Issue 2039773005: Add support in Chrome to send notifications to a specific device. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/dbus/bluetooth_gatt_application_service_provider.cc ('k') | device/bluetooth/dbus/bluetooth_gatt_characteristic_service_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/dbus/bluetooth_gatt_application_service_provider_unittest.cc

diff --git a/device/bluetooth/dbus/bluetooth_gatt_application_service_provider_unittest.cc b/device/bluetooth/dbus/bluetooth_gatt_application_service_provider_unittest.cc

index fecb8fe5792bb147b53664fefa475f15baab41ae..c0dd31603ef9a78035192322c4149410bade17c0 100644

--- a/device/bluetooth/dbus/bluetooth_gatt_application_service_provider_unittest.cc

+++ b/device/bluetooth/dbus/bluetooth_gatt_application_service_provider_unittest.cc

@@ -373,8 +373,9 @@ TEST_F(BluetoothGattApplicationServiceProviderTest, SendValueChanged) {

app_provider.get(), "characteristic0", kServicePath);

std::vector<uint8_t> kNewValue = {0x13, 0x37, 0xba, 0xad, 0xf0};

- app_provider->SendValueChanged(dbus::ObjectPath(kCharacteristicPath),

- kNewValue);

+ app_provider->SendValueChanged(dbus::ObjectPath(),

+ dbus::ObjectPath(kCharacteristicPath),

+ kNewValue, false);

// TODO(rkc): Write a test implementation of dbus::Bus and

// dbus::ExportedObject so we can capture the actual signal that is sent and

// verify its contents.