[Android] Added a runtime flag to enable autoplay of muted videos.

[Android] Added a runtime flag to enable autoplay of muted videos.

Allows autoplay of media if muted. Doesn't pause on unmute w/o user gesture yet.

BUG=617592, 617595
TEST=avayvod.github.io/autoplay-test.html

Committed: https://crrev.com/b28c363973c83300ef6c99c5433f1053fef4b2a7
Cr-Commit-Position: refs/heads/master@{#398840}

[whywhat, 2016-06-06 16:05:51]

avayvod@chromium.org changed reviewers:
+ mlamouri@chromium.org

[whywhat, 2016-06-06 16:05:52]

PTaL

[whywhat, 2016-06-06 16:05:58]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-06 16:06:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2039773003/1

[commit-bot: I haz the power, 2016-06-06 17:33:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 17:33:06]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[mlamouri (slow - plz ping), 2016-06-07 12:50:42]

lgtm if you remove the auto-pause behaviour. Better to have this in another CL
so we can use the flag for the other parts of the feature.

https://codereview.chromium.org/2039773003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/2039773003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:97: #define
MEDIA_LOG_LEVEL 0
Did you mean to change this?

https://codereview.chromium.org/2039773003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:2269: pause();
We should only have this behaviour for videos that got autoplayed because they
are muted. Maybe it could be done in a follow-up? :)

https://codereview.chromium.org/2039773003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:3671: return false;
I would leave this for another CL but you will need to keep track of whether the
media element autoplayed because it was muted.

[whywhat, 2016-06-07 14:18:36]

Removed the unmute logic and reverted the log level

[whywhat, 2016-06-07 14:20:08]

https://codereview.chromium.org/2039773003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/2039773003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:97: #define
MEDIA_LOG_LEVEL 0
On 2016/06/07 at 12:50:41, Mounir Lamouri (slow) wrote:
> Did you mean to change this?

Reverted.

https://codereview.chromium.org/2039773003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:2269: pause();
On 2016/06/07 at 12:50:41, Mounir Lamouri (slow) wrote:
> We should only have this behaviour for videos that got autoplayed because they
are muted. Maybe it could be done in a follow-up? :)

Removed.

https://codereview.chromium.org/2039773003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:3671: return false;
On 2016/06/07 at 12:50:41, Mounir Lamouri (slow) wrote:
> I would leave this for another CL but you will need to keep track of whether
the media element autoplayed because it was muted.

Ok.

[whywhat, 2016-06-07 14:23:39]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-07 14:23:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2039773003/20001

[whywhat, 2016-06-07 15:21:53]

An attempt to add a layout test.

[whywhat, 2016-06-07 15:22:21]

Description was changed from

==========
[Android] Added a runtime flag to enable autoplay of muted videos.

Pauses if unmuted without a user gesture.

BUG=617592
TEST=avayvod.github.io/autoplay-test.html
==========

to

==========
[Android] Added a runtime flag to enable autoplay of muted videos.

Allows autoplay of media if muted. Doesn't pause on unmute w/o user gesture yet.

BUG=617592
TEST=avayvod.github.io/autoplay-test.html
==========

[mlamouri (slow - plz ping), 2016-06-07 15:40:14]

https://codereview.chromium.org/2039773003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/autoplay-muted.html (right):

https://codereview.chromium.org/2039773003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/autoplay-muted.html:3: <script
src="../resource/testharness.js"></script>
You have a typo here I think :(

[whywhat, 2016-06-07 17:34:22]

Description was changed from

==========
[Android] Added a runtime flag to enable autoplay of muted videos.

Allows autoplay of media if muted. Doesn't pause on unmute w/o user gesture yet.

BUG=617592
TEST=avayvod.github.io/autoplay-test.html
==========

to

==========
[Android] Added a runtime flag to enable autoplay of muted videos.

Allows autoplay of media if muted. Doesn't pause on unmute w/o user gesture yet.

BUG=617592,617595
TEST=avayvod.github.io/autoplay-test.html
==========

[whywhat, 2016-06-07 17:39:36]

Fixed the layout test

[whywhat, 2016-06-07 17:40:15]

https://codereview.chromium.org/2039773003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/autoplay-muted.html (right):

https://codereview.chromium.org/2039773003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/autoplay-muted.html:3: <script
src="../resource/testharness.js"></script>
On 2016/06/07 at 15:40:14, Mounir Lamouri (slow) wrote:
> You have a typo here I think :(

Right, fixed :)

[whywhat, 2016-06-07 17:40:19]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-07 17:41:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2039773003/60001

[commit-bot: I haz the power, 2016-06-07 18:31:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 18:31:24]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[whywhat, 2016-06-07 19:20:38]

Simplified the test code

[whywhat, 2016-06-07 20:13:13]

Updated histograms.xml

[whywhat, 2016-06-07 20:14:43]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[whywhat, 2016-06-07 20:19:11]

avayvod@chromium.org changed reviewers:
+ dcheng@chromium.org, isherman@chromium.org, jochen@chromium.org

[whywhat, 2016-06-07 20:19:11]

Dear owners, ptal!

Your approval powers are needed!

isherman: tools/metrics/histograms/histograms.xml
dcheng: content/public/common/common_param_traits_macros.h
jochen: the rest of content/ and WebKit/

Thanks!

[commit-bot: I haz the power, 2016-06-07 20:32:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2039773003/100001

[Ilya Sherman, 2016-06-07 22:37:18]

histograms.xml lgtm

[commit-bot: I haz the power, 2016-06-07 23:18:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 23:18:37]

Dry run: This issue passed the CQ dry run.

[whywhat, 2016-06-08 12:38:04]

Restored const-ness of isGestureNeeded... method

[whywhat, 2016-06-08 12:38:31]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-08 12:38:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2039773003/120001

[whywhat, 2016-06-08 13:49:31]

Renamed the flag to autoplay-muted-videos

[whywhat, 2016-06-08 15:17:31]

The CQ bit was checked by avayvod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-08 15:18:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2039773003/140001

[commit-bot: I haz the power, 2016-06-08 19:41:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 19:41:15]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-06-08 23:56:02]

ipc lgtm

[jochen (gone - plz use gerrit), 2016-06-09 11:08:38]

lgtm

[whywhat, 2016-06-09 11:15:04]

The CQ bit was checked by avayvod@chromium.org

[whywhat, 2016-06-09 11:15:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2039773003/#ps140001
(title: "Renamed the flag to autoplay-muted-videos")

[commit-bot: I haz the power, 2016-06-09 11:15:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2039773003/140001

[commit-bot: I haz the power, 2016-06-09 11:19:20]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-06-09 11:20:43]

Description was changed from

==========
[Android] Added a runtime flag to enable autoplay of muted videos.

Allows autoplay of media if muted. Doesn't pause on unmute w/o user gesture yet.

BUG=617592,617595
TEST=avayvod.github.io/autoplay-test.html
==========

to

==========
[Android] Added a runtime flag to enable autoplay of muted videos.

Allows autoplay of media if muted. Doesn't pause on unmute w/o user gesture yet.

BUG=617592,617595
TEST=avayvod.github.io/autoplay-test.html

Committed: https://crrev.com/b28c363973c83300ef6c99c5433f1053fef4b2a7
Cr-Commit-Position: refs/heads/master@{#398840}
==========

[commit-bot: I haz the power, 2016-06-09 11:20:46]

Patchset 8 (id:??) landed as
https://crrev.com/b28c363973c83300ef6c99c5433f1053fef4b2a7
Cr-Commit-Position: refs/heads/master@{#398840}