[Android] Added a runtime flag to enable autoplay of muted videos.

third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

 /*
  * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 76 matching lines @@
 #include "public/platform/WebInbandTextTrack.h"
 #include "public/platform/WebMediaPlayerSource.h"
 #include "public/platform/WebMediaStream.h"
 #include "public/platform/modules/remoteplayback/WebRemotePlaybackClient.h"
 #include "public/platform/modules/remoteplayback/WebRemotePlaybackState.h"
 #include "wtf/CurrentTime.h"
 #include "wtf/MathExtras.h"
 #include "wtf/text/CString.h"
 #include <limits>
 
-#define MEDIA_LOG_LEVEL 3
+#define MEDIA_LOG_LEVEL 0

[mlamouri (slow - plz ping), 2016/06/07 12:50:41]

Did you mean to change this?

[whywhat, 2016/06/07 14:20:08]

Reverted.

 
 #ifndef LOG_MEDIA_EVENTS
 // Default to not logging events because so many are generated they can overwhelm the rest of
 // the logging.
 #define LOG_MEDIA_EVENTS 0
 #endif
 
 #ifndef LOG_CACHED_TIME_WARNINGS
 // Default to not logging warnings about excessive drift in the cached media time because it adds a
 // fair amount of overhead and logging.
@@ skipping 2149 matching lines @@
     m_autoplayHelper->mutedChanged();
 
     updateVolume();
 
     if (muted)
         Platform::current()->recordAction(UserMetricsAction("Media_Playback_Mute_On"));
     else
         Platform::current()->recordAction(UserMetricsAction("Media_Playback_Mute_Off"));
 
     scheduleEvent(EventTypeNames::volumechange);
+
+    if (!UserGestureIndicator::processingUserGesture())
+        pause();

[mlamouri (slow - plz ping), 2016/06/07 12:50:41]

We should only have this behaviour for videos that got autoplayed because they
are muted. Maybe it could be done in a follow-up? :)

[whywhat, 2016/06/07 14:20:08]

Removed.

 }
 
 void HTMLMediaElement::updateVolume()
 {
     if (webMediaPlayer())
         webMediaPlayer()->setVolume(effectiveMediaVolume());
 
     if (mediaControls())
         mediaControls()->updateVolume();
 }
@@ skipping 1377 matching lines @@
     return m_lockedPendingUserGesture;
 }
 
 void HTMLMediaElement::unlockUserGesture()
 {
     m_lockedPendingUserGesture = false;
 }
 
 bool HTMLMediaElement::isGestureNeededForPlayback() const
 {
-    return m_lockedPendingUserGesture
-        && !m_autoplayHelper->isGestureRequirementOverridden();
+    if (!m_lockedPendingUserGesture)
+        return false;
+
+    if (RuntimeEnabledFeatures::videosAsImagesEnabled() && muted())
+        return false;

[mlamouri (slow - plz ping), 2016/06/07 12:50:41]

I would leave this for another CL but you will need to keep track of whether the
media element autoplayed because it was muted.

[whywhat, 2016/06/07 14:20:08]

Ok.

+
+    if (m_autoplayHelper->isGestureRequirementOverridden())
+        return false;
+
+    return true;
 }
 
 void HTMLMediaElement::setNetworkState(NetworkState state)
 {
     if (m_networkState != state) {
         m_networkState = state;
         if (MediaControls* controls = mediaControls())
             controls->networkStateChanged();
     }
 }
@@ skipping 205 matching lines @@
 
 IntRect HTMLMediaElement::AutoplayHelperClientImpl::absoluteBoundingBoxRect() const
 {
     IntRect result;
     if (LayoutObject* object = m_element->layoutObject())
         result = object->absoluteBoundingBoxRect();
     return result;
 }
 
 } // namespace blink