third_party/WebKit/Source/core/html/HTMLMediaElement.cpp - Issue 2039773003: [Android] Added a runtime flag to enable autoplay of muted videos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

Issue 2039773003: [Android] Added a runtime flag to enable autoplay of muted videos. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Renamed the flag to autoplay-muted-videos Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/autoplay-muted.html ('k') | third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

index c938c39946b299731088bc3646a3cd1c29398fb9..441ee5b55a8b6e020d888087c1062bc553bea0e0 100644

--- a/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp

@@ -3673,8 +3673,16 @@ void HTMLMediaElement::unlockUserGesture()

bool HTMLMediaElement::isGestureNeededForPlayback() const

{

- return m_lockedPendingUserGesture

- && !m_autoplayHelper->isGestureRequirementOverridden();

+ if (!m_lockedPendingUserGesture)

+ return false;

+ if (muted() && RuntimeEnabledFeatures::autoplayMutedVideosEnabled())

+ return false;

+ if (m_autoplayHelper->isGestureRequirementOverridden())

+ return false;

+ return true;

}

void HTMLMediaElement::setNetworkState(NetworkState state)