FirstMeaningfulPaint UMA

chrome/common/page_load_metrics/page_load_timing.cc

Index: chrome/common/page_load_metrics/page_load_timing.cc
diff --git a/chrome/common/page_load_metrics/page_load_timing.cc b/chrome/common/page_load_metrics/page_load_timing.cc
index 4974384138a00527b8d3e4f0649e59f350a51d8e..f91e9031caeb7ff5cb5edf508c245d04c3534ae5 100644
--- a/chrome/common/page_load_metrics/page_load_timing.cc
+++ b/chrome/common/page_load_metrics/page_load_timing.cc
@@ -23,6 +23,8 @@ bool PageLoadTiming::operator==(const PageLoadTiming& other) const {
          first_paint == other.first_paint &&
          first_text_paint == other.first_text_paint &&
          first_image_paint == other.first_image_paint &&
+         first_contentful_paint == other.first_contentful_paint &&

[Bryan McQuade, 2016/07/29 15:02:26]

oh wow we weren't testing this in the equality implementation? yikes, thanks for
catching it. we should get that fix landed asap. i'll land it in a separate
change and we can merge to M53.

[Bryan McQuade, 2016/07/29 17:59:27]

I landed a fix for this here: https://codereview.chromium.org/2195743002

Note that you'll also need to update IsEmpty() below to include a test for
first_meaningful_paint.

[Kunihiko Sakamoto, 2016/08/01 08:52:07]

Done.

+         first_meaningful_paint == other.first_meaningful_paint &&
          parse_start == other.parse_start && parse_stop == other.parse_stop &&
          parse_blocked_on_script_load_duration ==
              other.parse_blocked_on_script_load_duration &&