FirstMeaningfulPaint UMA

chrome/common/page_load_metrics/page_load_timing.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/page_load_metrics/page_load_timing.h"
 
 namespace page_load_metrics {
 
 PageLoadTiming::PageLoadTiming() {}
 
 PageLoadTiming::PageLoadTiming(const PageLoadTiming& other) = default;
 
 PageLoadTiming::~PageLoadTiming() {}
 
 bool PageLoadTiming::operator==(const PageLoadTiming& other) const {
   return navigation_start == other.navigation_start &&
          response_start == other.response_start &&
          dom_loading == other.dom_loading &&
          dom_content_loaded_event_start ==
              other.dom_content_loaded_event_start &&
          load_event_start == other.load_event_start &&
          first_layout == other.first_layout &&
          first_paint == other.first_paint &&
          first_text_paint == other.first_text_paint &&
          first_image_paint == other.first_image_paint &&
+         first_contentful_paint == other.first_contentful_paint &&

[Bryan McQuade, 2016/07/29 15:02:26]

oh wow we weren't testing this in the equality implementation? yikes, thanks for
catching it. we should get that fix landed asap. i'll land it in a separate
change and we can merge to M53.

[Bryan McQuade, 2016/07/29 17:59:27]

I landed a fix for this here: https://codereview.chromium.org/2195743002

Note that you'll also need to update IsEmpty() below to include a test for
first_meaningful_paint.

[Kunihiko Sakamoto, 2016/08/01 08:52:07]

Done.

+         first_meaningful_paint == other.first_meaningful_paint &&
          parse_start == other.parse_start && parse_stop == other.parse_stop &&
          parse_blocked_on_script_load_duration ==
              other.parse_blocked_on_script_load_duration &&
          parse_blocked_on_script_load_from_document_write_duration ==
              other.parse_blocked_on_script_load_from_document_write_duration;
 }
 
 bool PageLoadTiming::IsEmpty() const {
   return navigation_start.is_null() && !response_start && !dom_loading &&
          !dom_content_loaded_event_start && !load_event_start &&
          !first_layout && !first_paint && !first_text_paint &&
          !first_image_paint && !parse_start && !parse_stop &&
          !parse_blocked_on_script_load_duration &&
          !parse_blocked_on_script_load_from_document_write_duration;
 }
 
 PageLoadMetadata::PageLoadMetadata() {}
 
 bool PageLoadMetadata::operator==(const PageLoadMetadata& other) const {
   return behavior_flags == other.behavior_flags;
 }
 
 }  // namespace page_load_metrics