[Typed OM] Add an "UnsupportedStyleValue" in C++ that just has a string for unknown types

Add an "UnsupportedStyleValue" in C++ that just has a string for use
on not-yet-supported or unknown types.

In JavaScript, this object is just a base CSSStyleValue as per the
spec:  https://drafts.css-houdini.org/css-typed-om/#stylevalue-objects

BUG=545318
Committed: https://crrev.com/1af6e80ef2424e321f99b38c386b6a8d63b0416a
Cr-Commit-Position: refs/heads/master@{#398820}

[meade_UTC10, 2016-06-08 02:07:11]

Description was changed from

==========
Add an "UnsupportedStyleValue" that just has a string for use on
not-yet-supported or unknown types.

BUG=545318
==========

to

==========
Add an "UnsupportedStyleValue" in C++ that just has a string for use on
not-yet-supported or unknown types.

In JavaScript, this object is just a base CSSStyleValue as per the
spec:  https://drafts.css-houdini.org/css-typed-om/#stylevalue-objects

BUG=545318
==========

[meade_UTC10, 2016-06-08 02:07:56]

Description was changed from

==========
Add an "UnsupportedStyleValue" in C++ that just has a string for use on
not-yet-supported or unknown types.

In JavaScript, this object is just a base CSSStyleValue as per the
spec:  https://drafts.css-houdini.org/css-typed-om/#stylevalue-objects

BUG=545318
==========

to

==========
Add an "UnsupportedStyleValue" in C++ that just has a string for use on
not-yet-supported or unknown types.

In JavaScript, this object is just a base CSSStyleValue as per the
spec:  https://drafts.css-houdini.org/css-typed-om/#stylevalue-objects

BUG=545318
==========

[meade_UTC10, 2016-06-08 02:08:15]

Description was changed from

==========
Add an "UnsupportedStyleValue" in C++ that just has a string for use on
not-yet-supported or unknown types.

In JavaScript, this object is just a base CSSStyleValue as per the
spec:  https://drafts.css-houdini.org/css-typed-om/#stylevalue-objects

BUG=545318
==========

to

==========
Add an "UnsupportedStyleValue" in C++ that just has a string for use
on not-yet-supported or unknown types.

In JavaScript, this object is just a base CSSStyleValue as per the
spec:  https://drafts.css-houdini.org/css-typed-om/#stylevalue-objects

BUG=545318
==========

[meade_UTC10, 2016-06-08 02:09:11]

meade@chromium.org changed reviewers:
+ shans@chromium.org, timloh@chromium.org

[meade_UTC10, 2016-06-08 02:09:11]

PTAL. I'm not terribly happy with the toCSSValue() vs toCSSValue(CSSPropertyID)
thing, and would like to hear your opinions.

[ikilpatrick, 2016-06-08 20:20:43]

ikilpatrick@chromium.org changed reviewers:
+ ikilpatrick@chromium.org

[ikilpatrick, 2016-06-08 20:20:44]

https://codereview.chromium.org/2038773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.h
(right):

https://codereview.chromium.org/2038773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.h:15: static
CSSUnsupportedStyleValue* create(CSSPropertyID propertyID, const String&
cssText)
This will work for variables as well?

E.g.
CSSUnsupportedStyleValue::create(CSSPropertyInvalid, "resolved variable
string");

[meade_UTC10, 2016-06-09 05:56:30]

I moved the code I did't like into a helper function :)

https://codereview.chromium.org/2038773002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.h
(right):

https://codereview.chromium.org/2038773002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.h:15: static
CSSUnsupportedStyleValue* create(CSSPropertyID propertyID, const String&
cssText)
On 2016/06/08 20:20:43, ikilpatrick wrote:
> This will work for variables as well?
> 
> E.g.
> CSSUnsupportedStyleValue::create(CSSPropertyInvalid, "resolved variable
> string");

Actually I don't think this is necessary here. Removed the propertyID.

[shans, 2016-06-09 06:42:07]

lgtm

[Timothy Loh, 2016-06-09 07:22:24]

lgtm

https://codereview.chromium.org/2038773002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl
(right):

https://codereview.chromium.org/2038773002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl:25: // The
check has to happen later in this case.
has to happen -> happens? Seems to me like we could try parsing the value here
if we wanted to.

https://codereview.chromium.org/2038773002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp
(right):

https://codereview.chromium.org/2038773002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp:74: // TODO:
Use a builder instead of appending like this.
Not sure what you're after here, this is just how CSSValueLists are built at the
moment.

[meade_UTC10, 2016-06-09 07:50:53]

https://codereview.chromium.org/2038773002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl
(right):

https://codereview.chromium.org/2038773002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl:25: // The
check has to happen later in this case.
On 2016/06/09 07:22:24, Timothy Loh wrote:
> has to happen -> happens? Seems to me like we could try parsing the value here
> if we wanted to.

Done.

https://codereview.chromium.org/2038773002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp
(right):

https://codereview.chromium.org/2038773002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp:74: // TODO:
Use a builder instead of appending like this.
On 2016/06/09 07:22:24, Timothy Loh wrote:
> Not sure what you're after here, this is just how CSSValueLists are built at
the
> moment.

Misplaced comment from a discussion with Sasha... Removed.

[meade_UTC10, 2016-06-09 07:51:25]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2016-06-09 07:51:26]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org,
shans@chromium.org
Link to the patchset: https://codereview.chromium.org/2038773002/#ps80001
(title: "Address comments about comments")

[commit-bot: I haz the power, 2016-06-09 07:51:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2038773002/80001

[commit-bot: I haz the power, 2016-06-09 09:16:21]

Description was changed from

==========
Add an "UnsupportedStyleValue" in C++ that just has a string for use
on not-yet-supported or unknown types.

In JavaScript, this object is just a base CSSStyleValue as per the
spec:  https://drafts.css-houdini.org/css-typed-om/#stylevalue-objects

BUG=545318
==========

to

==========
Add an "UnsupportedStyleValue" in C++ that just has a string for use
on not-yet-supported or unknown types.

In JavaScript, this object is just a base CSSStyleValue as per the
spec:  https://drafts.css-houdini.org/css-typed-om/#stylevalue-objects

BUG=545318
==========

[commit-bot: I haz the power, 2016-06-09 09:16:22]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-09 09:17:54]

Description was changed from

==========
Add an "UnsupportedStyleValue" in C++ that just has a string for use
on not-yet-supported or unknown types.

In JavaScript, this object is just a base CSSStyleValue as per the
spec:  https://drafts.css-houdini.org/css-typed-om/#stylevalue-objects

BUG=545318
==========

to

==========
Add an "UnsupportedStyleValue" in C++ that just has a string for use
on not-yet-supported or unknown types.

In JavaScript, this object is just a base CSSStyleValue as per the
spec:  https://drafts.css-houdini.org/css-typed-om/#stylevalue-objects

BUG=545318

Committed: https://crrev.com/1af6e80ef2424e321f99b38c386b6a8d63b0416a
Cr-Commit-Position: refs/heads/master@{#398820}
==========

[commit-bot: I haz the power, 2016-06-09 09:17:55]

Patchset 5 (id:??) landed as
https://crrev.com/1af6e80ef2424e321f99b38c386b6a8d63b0416a
Cr-Commit-Position: refs/heads/master@{#398820}