Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: third_party/WebKit/Source/core/css/cssom/CSSStyleValue.h

Issue 2038773002: [Typed OM] Add an "UnsupportedStyleValue" in C++ that just has a string for unknown types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@stylevaue
Patch Set: Address comments about comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/CSSStyleValue.h
diff --git a/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.h b/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.h
index b868edbac6017eca704b10b58145757e5e81bc13..8375da22258e9201f8699ab53ed2269ec3bc72b1 100644
--- a/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.h
+++ b/third_party/WebKit/Source/core/css/cssom/CSSStyleValue.h
@@ -6,6 +6,7 @@
#define CSSStyleValue_h
#include "bindings/core/v8/ScriptWrappable.h"
+#include "core/CSSPropertyNames.h"
#include "core/CoreExport.h"
#include "core/css/CSSValue.h"
@@ -20,6 +21,7 @@ class CORE_EXPORT CSSStyleValue : public GarbageCollectedFinalized<CSSStyleValue
DEFINE_WRAPPERTYPEINFO();
public:
enum StyleValueType {
+ Unknown,
AngleType,
CalcLengthType,
KeywordType,
@@ -36,6 +38,10 @@ public:
static ScriptValue parse(ScriptState*, const String& propertyName, const String& value, ExceptionState&);
virtual CSSValue* toCSSValue() const = 0;
+ virtual CSSValue* toCSSValueWithProperty(CSSPropertyID) const
+ {
+ return toCSSValue();
+ }
virtual String cssString() const
{
return toCSSValue()->cssText();
« no previous file with comments | « third_party/WebKit/Source/core/core.gypi ('k') | third_party/WebKit/Source/core/css/cssom/CSSUnsupportedStyleValue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698