Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2038743002: Support ARB extensions for indirect drawing (Closed)

Created:
4 years, 6 months ago by csmartdalton
Modified:
4 years, 6 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Support ARB extensions for indirect drawing Adds support for the ARB extensions and fixes incorrect logic that was being used on the GL version for indirect drawing. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2038743002 Committed: https://skia.googlesource.com/skia/+/5cebf8c82dfe3fc4110944f0db03d7fc85b7142a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -23 lines) Patch
M include/gpu/gl/GrGLInterface.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 5 chunks +13 lines, -13 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +6 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
csmartdalton
4 years, 6 months ago (2016-06-03 05:59:30 UTC) #3
bsalomon
lgtm
4 years, 6 months ago (2016-06-03 14:35:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2038743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2038743002/1
4 years, 6 months ago (2016-06-03 15:09:56 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-03 15:28:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5cebf8c82dfe3fc4110944f0db03d7fc85b7142a

Powered by Google App Engine
This is Rietveld 408576698