[Mac/GN] When using debug_devtools=true, bundle the inspector resources using a symlink.

[Mac/GN] When using debug_devtools=true, bundle the inspector resources using a symlink.

BUG=616657
R=pfeldman@chromium.org,thakis@chromium.org

Committed: https://crrev.com/c40350d041c6916ef0c141423779b73624277273
Cr-Commit-Position: refs/heads/master@{#398046}

[Robert Sesek, 2016-06-02 17:44:01]

Patchset #1 (id:1) has been deleted

[Nico, 2016-06-02 18:03:47]

lgtm except for the deletion of DEBUG_DEVTOOLS which the cl description doesn't
motivate, and which is around in the gyp build.

Looks like this only works for chrome, not content shell, in the gyp build as
well.

https://codereview.chromium.org/2038593002/diff/20001/chrome/BUILD.gn
File chrome/BUILD.gn (right):

https://codereview.chromium.org/2038593002/diff/20001/chrome/BUILD.gn#newcode721
chrome/BUILD.gn:721: script = "//build/rmdir_and_stamp.py"
rmdir_and_stamp removes the symlink, not the contents of the directory the
symlink links to, yes?

https://codereview.chromium.org/2038593002/diff/20001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (left):

https://codereview.chromium.org/2038593002/diff/20001/chrome/test/BUILD.gn#ol...
chrome/test/BUILD.gn:1048: defines += [ "DEBUG_DEVTOOLS=1" ]
why is this going away?

[Robert Sesek, 2016-06-02 18:20:08]

On 2016/06/02 18:03:47, Nico wrote:
> Looks like this only works for chrome, not content shell, in the gyp build as
> well.

Right, just copying the GYP setup here.

https://codereview.chromium.org/2038593002/diff/20001/chrome/BUILD.gn
File chrome/BUILD.gn (right):

https://codereview.chromium.org/2038593002/diff/20001/chrome/BUILD.gn#newcode721
chrome/BUILD.gn:721: script = "//build/rmdir_and_stamp.py"
On 2016/06/02 18:03:46, Nico wrote:
> rmdir_and_stamp removes the symlink, not the contents of the directory the
> symlink links to, yes?

Correct.

https://codereview.chromium.org/2038593002/diff/20001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (left):

https://codereview.chromium.org/2038593002/diff/20001/chrome/test/BUILD.gn#ol...
chrome/test/BUILD.gn:1048: defines += [ "DEBUG_DEVTOOLS=1" ]
On 2016/06/02 18:03:46, Nico wrote:
> why is this going away?

I switched to using the config, which all other places use.

https://code.google.com/p/chromium/codesearch#search/&q=debug_devtools%20file...

[Nico, 2016-06-02 18:37:05]

lgtm

[Robert Sesek, 2016-06-02 18:41:56]

https://codereview.chromium.org/2038593002/diff/20001/chrome/BUILD.gn
File chrome/BUILD.gn (right):

https://codereview.chromium.org/2038593002/diff/20001/chrome/BUILD.gn#newcode721
chrome/BUILD.gn:721: script = "//build/rmdir_and_stamp.py"
On 2016/06/02 18:20:08, Robert Sesek wrote:
> On 2016/06/02 18:03:46, Nico wrote:
> > rmdir_and_stamp removes the symlink, not the contents of the directory the
> > symlink links to, yes?
> 
> Correct.

Actually, the rmdir is unnecessary because when copy_bundle_data copies the
framework, it will be deleted first if it exists. Simplified!

(I previously was putting it in .framework to get copied into .app, but
copy_bundle_data traverses symlinks rather than copying the link itself).

[Nico, 2016-06-02 18:44:34]

https://codereview.chromium.org/2038593002/diff/20001/chrome/BUILD.gn
File chrome/BUILD.gn (right):

https://codereview.chromium.org/2038593002/diff/20001/chrome/BUILD.gn#newcode721
chrome/BUILD.gn:721: script = "//build/rmdir_and_stamp.py"
On 2016/06/02 18:41:56, Robert Sesek wrote:
> On 2016/06/02 18:20:08, Robert Sesek wrote:
> > On 2016/06/02 18:03:46, Nico wrote:
> > > rmdir_and_stamp removes the symlink, not the contents of the directory the
> > > symlink links to, yes?
> > 
> > Correct.
> 
> Actually, the rmdir is unnecessary because when copy_bundle_data copies the
> framework, it will be deleted first if it exists. Simplified!
> 
> (I previously was putting it in .framework to get copied into .app, but
> copy_bundle_data traverses symlinks rather than copying the link itself).

I figured the rmdir is here so that if you remove devtools_debug, the symlink
disappears on the next build

[Robert Sesek, 2016-06-02 18:47:11]

https://codereview.chromium.org/2038593002/diff/20001/chrome/BUILD.gn
File chrome/BUILD.gn (right):

https://codereview.chromium.org/2038593002/diff/20001/chrome/BUILD.gn#newcode721
chrome/BUILD.gn:721: script = "//build/rmdir_and_stamp.py"
On 2016/06/02 18:44:34, Nico wrote:
> On 2016/06/02 18:41:56, Robert Sesek wrote:
> > On 2016/06/02 18:20:08, Robert Sesek wrote:
> > > On 2016/06/02 18:03:46, Nico wrote:
> > > > rmdir_and_stamp removes the symlink, not the contents of the directory
the
> > > > symlink links to, yes?
> > > 
> > > Correct.
> > 
> > Actually, the rmdir is unnecessary because when copy_bundle_data copies the
> > framework, it will be deleted first if it exists. Simplified!
> > 
> > (I previously was putting it in .framework to get copied into .app, but
> > copy_bundle_data traverses symlinks rather than copying the link itself).
> 
> I figured the rmdir is here so that if you remove devtools_debug, the symlink
> disappears on the next build

If you remove devtools_debug, it will create a new .pak, which causes a repak
action to run, which gets put in the .framework/Resources, which then gets
copied to .app. Copying .framework to .app will cause the old .framework to get
rmtree()'d itself, so the link gets removed.

[Robert Sesek, 2016-06-03 18:42:08]

pfeldman: any comments?

[Robert Sesek, 2016-06-03 18:42:08]

pfeldman: any comments?

[Robert Sesek, 2016-06-06 15:20:20]

The CQ bit was checked by rsesek@chromium.org

[Robert Sesek, 2016-06-06 15:20:21]

The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2038593002/#ps40001
(title: "Simplify")

[commit-bot: I haz the power, 2016-06-06 15:20:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2038593002/40001

[commit-bot: I haz the power, 2016-06-06 16:27:38]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-06-06 16:29:03]

Description was changed from

==========
[Mac/GN] When using debug_devtools=true, bundle the inspector resources using a
symlink.

BUG=616657
R=pfeldman@chromium.org,thakis@chromium.org
==========

to

==========
[Mac/GN] When using debug_devtools=true, bundle the inspector resources using a
symlink.

BUG=616657
R=pfeldman@chromium.org,thakis@chromium.org

Committed: https://crrev.com/c40350d041c6916ef0c141423779b73624277273
Cr-Commit-Position: refs/heads/master@{#398046}
==========

[commit-bot: I haz the power, 2016-06-06 16:29:06]

Patchset 2 (id:??) landed as
https://crrev.com/c40350d041c6916ef0c141423779b73624277273
Cr-Commit-Position: refs/heads/master@{#398046}