Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1402)

Side by Side Diff: chrome/BUILD.gn

Issue 2038593002: [Mac/GN] When using debug_devtools=true, bundle the inspector resources using a symlink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Simplify Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/test/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/locales.gni") 9 import("//build/config/locales.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 401 matching lines...) Expand 10 before | Expand all | Expand 10 after
412 } 412 }
413 } 413 }
414 } else if (is_mac) { 414 } else if (is_mac) {
415 chrome_helper_name = chrome_product_full_name + " Helper" 415 chrome_helper_name = chrome_product_full_name + " Helper"
416 chrome_framework_name = chrome_product_full_name + " Framework" 416 chrome_framework_name = chrome_product_full_name + " Framework"
417 417
418 group("chrome") { 418 group("chrome") {
419 deps = [ 419 deps = [
420 ":chrome_app", 420 ":chrome_app",
421 ] 421 ]
422
423 if (debug_devtools) {
424 deps += [ ":devtools_debug_resources" ]
425 }
422 } 426 }
423 427
424 tweak_info_plist("chrome_app_plist") { 428 tweak_info_plist("chrome_app_plist") {
425 info_plist = "app/app-Info.plist" 429 info_plist = "app/app-Info.plist"
426 _keystone_arg = "0" 430 _keystone_arg = "0"
427 if (enable_mac_keystone) { 431 if (enable_mac_keystone) {
428 _keystone_arg = "1" 432 _keystone_arg = "1"
429 } 433 }
430 args = [ 434 args = [
431 "--breakpad=0", 435 "--breakpad=0",
(...skipping 247 matching lines...) Expand 10 before | Expand all | Expand 10 after
679 683
680 if (v8_use_external_startup_data) { 684 if (v8_use_external_startup_data) {
681 sources += [ 685 sources += [
682 "$root_out_dir/natives_blob.bin", 686 "$root_out_dir/natives_blob.bin",
683 "$root_out_dir/snapshot_blob.bin", 687 "$root_out_dir/snapshot_blob.bin",
684 ] 688 ]
685 public_deps += [ "//v8" ] 689 public_deps += [ "//v8" ]
686 } 690 }
687 } 691 }
688 692
693 # When debug_devtools is enabled, symlink the inspector resources into the
694 # framework bundle. The resources go into the final output directory for the
695 # framework in the app bundle, rather than the framework bundle in
696 # root_out_dir, since copy_bundle_data copies the contents of the link
697 # rather than the link itself.
698 action("devtools_debug_resources") {
699 _stamp = "$target_out_dir/run_${target_name}.stamp"
700
701 outputs = [
702 _stamp,
703 ]
704
705 script = "//build/symlink.py"
706 args = [
707 "-f",
708 "--touch",
709 rebase_path(_stamp, root_out_dir),
710
711 # Convert the symlink source and destination to an absolute paths, which
712 # makes symlinking easier (now pwd manipulation).
713 rebase_path("$root_out_dir/resources/inspector"),
714 rebase_path(
715 "$root_out_dir/$chrome_product_full_name.app/Contents/Versions/$chrome _version_full/$chrome_framework_name.framework/Resources/inspector"),
716 ]
717
718 deps = [
719 # Depend on :chrome_app to ensure that the bundle is produced before
720 # creating or destroying the symlink.
721 ":chrome_app",
722 "//third_party/WebKit/public:blink_devtools_frontend_resources",
723 ]
724 }
725
689 if (enable_nacl) { 726 if (enable_nacl) {
690 bundle_data("chrome_framework_plugins") { 727 bundle_data("chrome_framework_plugins") {
691 sources = [] 728 sources = []
692 outputs = [ 729 outputs = [
693 "{{bundle_root_dir}}/Internet Plug-Ins/{{source_file_part}}", 730 "{{bundle_root_dir}}/Internet Plug-Ins/{{source_file_part}}",
694 ] 731 ]
695 public_deps = [] 732 public_deps = []
696 733
697 if (enable_nacl) { 734 if (enable_nacl) {
698 sources += [ "$root_out_dir/nacl_irt_x86_64.nexe" ] 735 sources += [ "$root_out_dir/nacl_irt_x86_64.nexe" ]
(...skipping 868 matching lines...) Expand 10 before | Expand all | Expand 10 after
1567 "//chrome/app/theme/$branding_path_component/product_logo_48.png", 1604 "//chrome/app/theme/$branding_path_component/product_logo_48.png",
1568 "//chrome/tools/build/linux/chrome-wrapper", 1605 "//chrome/tools/build/linux/chrome-wrapper",
1569 "//third_party/xdg-utils/scripts/xdg-mime", 1606 "//third_party/xdg-utils/scripts/xdg-mime",
1570 "//third_party/xdg-utils/scripts/xdg-settings", 1607 "//third_party/xdg-utils/scripts/xdg-settings",
1571 ] 1608 ]
1572 outputs = [ 1609 outputs = [
1573 "$root_out_dir/{{source_file_part}}", 1610 "$root_out_dir/{{source_file_part}}",
1574 ] 1611 ]
1575 } 1612 }
1576 } 1613 }
OLDNEW
« no previous file with comments | « no previous file | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698