Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Unified Diff: chrome/BUILD.gn

Issue 2038593002: [Mac/GN] When using debug_devtools=true, bundle the inspector resources using a symlink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Simplify Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 6fb3011e30b37472da5828c3bb5e8ec69028e2e1..aae9d788c2c9263c0890403a2eec516db3fa48db 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -419,6 +419,10 @@ if (is_win) {
deps = [
":chrome_app",
]
+
+ if (debug_devtools) {
+ deps += [ ":devtools_debug_resources" ]
+ }
}
tweak_info_plist("chrome_app_plist") {
@@ -686,6 +690,39 @@ if (is_win) {
}
}
+ # When debug_devtools is enabled, symlink the inspector resources into the
+ # framework bundle. The resources go into the final output directory for the
+ # framework in the app bundle, rather than the framework bundle in
+ # root_out_dir, since copy_bundle_data copies the contents of the link
+ # rather than the link itself.
+ action("devtools_debug_resources") {
+ _stamp = "$target_out_dir/run_${target_name}.stamp"
+
+ outputs = [
+ _stamp,
+ ]
+
+ script = "//build/symlink.py"
+ args = [
+ "-f",
+ "--touch",
+ rebase_path(_stamp, root_out_dir),
+
+ # Convert the symlink source and destination to an absolute paths, which
+ # makes symlinking easier (now pwd manipulation).
+ rebase_path("$root_out_dir/resources/inspector"),
+ rebase_path(
+ "$root_out_dir/$chrome_product_full_name.app/Contents/Versions/$chrome_version_full/$chrome_framework_name.framework/Resources/inspector"),
+ ]
+
+ deps = [
+ # Depend on :chrome_app to ensure that the bundle is produced before
+ # creating or destroying the symlink.
+ ":chrome_app",
+ "//third_party/WebKit/public:blink_devtools_frontend_resources",
+ ]
+ }
+
if (enable_nacl) {
bundle_data("chrome_framework_plugins") {
sources = []
« no previous file with comments | « no previous file | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698