third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp - Issue 2038443003: Made ElementStyleResources store const CSSSVGDocumentValues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

Issue 2038443003: Made ElementStyleResources store const CSSSVGDocumentValues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@+delete_nonconst_cssvaluelist_item_function

Patch Set: Rebase Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp b/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

index e1e671a0da9c6391da0d09211113c100f9c6f984..e3e31856eaa00791d253b9d674525b2f9a3d72d0 100644

--- a/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

@@ -135,7 +135,7 @@ FilterOperations FilterOperationResolver::createFilterOperations(StyleResolverSt

ASSERT(filterValue->length() <= 1);

if (operationType == FilterOperation::REFERENCE) {

- CSSSVGDocumentValue* svgDocumentValue = toCSSSVGDocumentValue(filterValue->item(0));

+ const CSSSVGDocumentValue* svgDocumentValue = toCSSSVGDocumentValue(filterValue->item(0));

KURL url = state.document().completeURL(svgDocumentValue->url());

ReferenceFilterOperation* operation = ReferenceFilterOperation::create(svgDocumentValue->url(), AtomicString(url.fragmentIdentifier()));

« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/ElementStyleResources.cpp ('k') | no next file » | no next file with comments »