Mojo C++ bindings GYP build: only unset "-Wglobal-constructors' for unittests depending on WTF type…

Mojo C++ bindings GYP build: only unset "-Wglobal-constructors' for unittests depending on WTF types.

BUG=583738
Committed: https://crrev.com/8576d4ca0294a68c69158b5f7ba03a9a1dbd4cc0
Cr-Commit-Position: refs/heads/master@{#398162}

[yzshen1, 2016-06-06 19:33:47]

yzshen@chromium.org changed reviewers:
+ thakis@chromium.org

[yzshen1, 2016-06-06 19:33:47]

Hi, Nico.

PTAL. Thanks!

[Nico, 2016-06-06 19:35:06]

lgtm, thanks!

Is the flag test-only in gn builds already?

[yzshen1, 2016-06-06 19:42:34]

On 2016/06/06 19:35:06, Nico wrote:
> lgtm, thanks!
> 
> Is the flag test-only in gn builds already?

GN is doing the opposite: non-testing targets explicitly set this flag by
applying third_party/WebKit/Source:non_test_config.
(That is because in GN we cannot unset a flag if it is inherited from a
dependent, AFAIK.)
So there is no changes needed there.

[yzshen1, 2016-06-06 20:22:58]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2016-06-06 20:23:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2038413003/1

[commit-bot: I haz the power, 2016-06-07 00:12:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-07 00:14:15]

Description was changed from

==========
Mojo C++ bindings GYP build: only unset "-Wglobal-constructors' for unittests
depending on WTF types.

BUG=583738
==========

to

==========
Mojo C++ bindings GYP build: only unset "-Wglobal-constructors' for unittests
depending on WTF types.

BUG=583738

Committed: https://crrev.com/8576d4ca0294a68c69158b5f7ba03a9a1dbd4cc0
Cr-Commit-Position: refs/heads/master@{#398162}
==========

[commit-bot: I haz the power, 2016-06-07 00:14:16]

Patchset 1 (id:??) landed as
https://crrev.com/8576d4ca0294a68c69158b5f7ba03a9a1dbd4cc0
Cr-Commit-Position: refs/heads/master@{#398162}